Skip to content

Node: Guard synthetic model list compatibility #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
andysalerno wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Node: Guard synthetic model list compatibility #2404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion nodejs/test/client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
type GitHubTelemetryNotification,
type ModelInfo,
} from "../src/index.js";
import type { Model } from "../src/generated/rpc.js";
import { CopilotSession } from "../src/session.js";
import { defaultJoinSessionPermissionHandler } from "../src/types.js";

Expand Down Expand Up @@ -2854,7 +2855,32 @@ describe("CopilotClient", () => {
});
});

describe("onListModels", () => {
describe("model listing", () => {
it("preserves synthetic model identifiers and picker metadata through models.list", async () => {
const models: Model[] = [
{
id: "hydrafusion",
name: "HydraFusion",
capabilities: {},
modelPickerCategory: "powerful",
},
{
id: "hydrafusion-max",
name: "HydraFusion Max",
capabilities: {},
modelPickerCategory: "powerful",
},
];
const sendRequest = vi.fn().mockResolvedValue({ models });
const client = new CopilotClient();
(client as any).connection = { sendRequest };

const result = await client.rpc.models.list({});

expect(sendRequest).toHaveBeenCalledWith("models.list", {});
expect(result.models).toEqual(models);
});

it("calls onListModels handler instead of RPC when provided", async () => {
const customModels: ModelInfo[] = [
{
Expand Down
Loading