Repository navigation
Add PR triage skill - #5404
Add PR triage skill#5404tomthorogood wants to merge 12 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Update priority list for PR triage guidelines. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Really nice. The one procedural question that reading the skill raised for me: it should be OK for people to add their projects to existing collections, right? I don't feel like that's the same level of conflict of interest as people adding a whole topic or brand-new collection for their pet projects. |
This comment was marked as low quality.
This comment was marked as low quality.
1 similar comment
This comment was marked as low quality.
This comment was marked as low quality.
@ahpook great question. I always assumed the opposite but if I've been too restrictive, this is the time to canonize it! |
|
No you're right – that's what the rules say, I just personally think it's nbd if the user is appending to an existing collection with their own project. |
| 4. **PRs editing core repository metadata** (workflows, CI config, `Gemfile`, docs, etc. — anything outside `topics/` or `collections/`) submitted by an external contributor: ❌. This repository only accepts topic/collection contributions from the community; infrastructure changes need maintainer review through other channels. | ||
| 5. **PRs that add or edit a topic or collection**: | ||
| - Check the PR description against `.github/PULL_REQUEST_TEMPLATE.md`. If the required checkboxes for the selected contribution type are not checked, recommend ❌ — per `CONTRIBUTING.md`, incomplete templates are closed without comment. | ||
| - If the checkboxes are complete but the contribution reads as self-promotion (e.g. the author is adding their own repository to a topic or collection), check the PR description and comments for a disclosed, extenuating explanation (e.g. independent evidence of community adoption, or a maintainer acknowledgment) that might justify an exception. Absent such justification, recommend ❌ citing the "Avoid conflicts of interest" guideline in `CONTRIBUTING.md`. |
There was a problem hiding this comment.
| - If the checkboxes are complete but the contribution reads as self-promotion (e.g. the author is adding their own repository to a topic or collection), check the PR description and comments for a disclosed, extenuating explanation (e.g. independent evidence of community adoption, or a maintainer acknowledgment) that might justify an exception. Absent such justification, recommend ❌ citing the "Avoid conflicts of interest" guideline in `CONTRIBUTING.md`. | |
| - If the checkboxes are complete but the contribution reads as self-promotion (e.g. the author is adding their own repository to a topic), check the PR description and comments for a disclosed, extenuating explanation (e.g. independent evidence of community adoption, or a maintainer acknowledgment) that might justify an exception. Absent such justification, recommend ❌ citing the "Avoid conflicts of interest" guideline in `CONTRIBUTING.md`. One exception to the no-self-promotion rule: users may add their own repositories to already-existing collections, especially the `made-in-*` geography-based collections. |
@tomthorogood wdyt, this codifies the mental logic i go through for these changes.
Adds
.github/skills/pr-triage/SKILL.md, documenting the process for triaging open PRs in this repo (recommendation rules, staged resolution order, CI failure diagnosis).After invoking the skill to generate the working table, you can prompt copilot to do things like:
...and so forth.
This has greatly helped me processing this queue. If you like it I can do something similar for opensource.guide ❤️