fix: correct firewall issue dispatcher tracking issue link format#2161
fix: correct firewall issue dispatcher tracking issue link format#2161
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Firewall Issue Dispatcher agentic workflow prompt to prevent malformed cross-repo tracking-issue links by explicitly requiring extraction of the numeric issue ID from create_issue outputs.
Changes:
- Clarifies that
create_issuereferences likegithub/gh-aw-firewall#2159must be converted to a numeric ID before building the URL. - Adds explicit valid/invalid URL examples to prevent malformed
/issues/...links. - Removes duplicated wording in the comment-format instructions.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/firewall-issue-dispatcher.md | Tightens the prompt instructions for composing tracking-issue links and adds examples to avoid malformed URLs. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
| `create_issue` may return a reference like `github/gh-aw-firewall#2159`. Extract only the trailing digits before composing the URL. | ||
| - Valid: `https://github.com/github/gh-aw-firewall/issues/2159` | ||
| - Invalid: `https://github.com/github/gh-aw-firewall/issues/github/gh-aw-firewall#2159` | ||
| - Invalid: `https://github.com/github/gh-aw-firewall/issues/#2159` | ||
|
|
||
| where `{NUMBER}` is replaced with **only the numeric issue number** (e.g., `1896`). Do NOT include the repository name, hash symbols, or any other text — just the number in the URL path. Use the `add_comment` safe output tool with `repo: "github/gh-aw"` and the original issue number. | ||
| Use the `add_comment` safe output tool with `repo: "github/gh-aw"` and the original issue number. |
There was a problem hiding this comment.
This workflow has a compiled companion .lock.yml and the compiled job includes a lock staleness check; updating the .md without regenerating firewall-issue-dispatcher.lock.yml will cause the workflow to report a stale lock file (and may keep the runtime prompt out of sync). Please run gh aw compile and commit the updated .github/workflows/firewall-issue-dispatcher.lock.yml in this PR.
|
@copilot address this review feedback #2161 (review) |
Smoke Test Results✅ GitHub MCP Testing Status: PASS
|
🔥 Smoke Test Results
Overall: PASS (core tests green) /cc
|
🔥 Smoke Test: Copilot BYOK (Offline) Mode
Running in BYOK offline mode ( Overall: PASS (core BYOK path verified) PR by
|
🏗️ Build Test Suite Results
Overall: 0/8 ecosystems passed — ❌ FAIL Error detailsAll repositories failed to clone with the same error: The
|
|
Smoke test results:
Warning The following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Smoke Test Results: GitHub Actions Services Connectivity
Summary: All 3 checks failed.
|
Addressed. I recompiled and committed Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Summary
/issues/github/gh-aw-firewall#2159Validation
npm run lint && npm run build✅npm testsrc/docker-manager.test.ts(should create missing .copilot directory and mount it when using non-standard HOME path)parallel_validation✅ (Code Review + CodeQL)