docs: add D13 sbx daemon egress diagnosis - #8358
Merged
Merged
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update Runner Doctor with new lesson on Squid egress enforcement
docs: add D13 sbx daemon egress diagnosis
Sep 9, 2026
lpcox
marked this pull request as ready for review
September 9, 2026 22:44
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The required portable doctor copy and its synchronization assertions are missing.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Documents D13, the fail-closed sbx daemon egress diagnostic.
Changes:
- Adds D13 symptoms, cause, remediation, and lookup guidance.
- Adds regression assertions for workflow documentation.
File summaries
| File | Description |
|---|---|
scripts/ci/self-hosted-runner-doctor-workflow.test.ts |
Tests D13 documentation. |
.github/workflows/shared/self-hosted-failure-modes.md |
Adds D13 to the shared catalog. |
.github/workflows/self-hosted-runner-doctor.md |
Adds D13 diagnostic guidance. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+206
to
+208
| expect(shared).toContain('| D13 | Under `--container-runtime sbx` with `network.verifySbxEgress`/`--verify-sbx-egress` enabled, AWF reports `Direct sbx egress reached 1.1.1.1 without proxy environment variables`'); | ||
| expect(shared).toContain('github/gh-aw-firewall#8250, github/gh-aw-firewall#8252'); | ||
| expect(shared).toContain('| `Direct sbx egress reached 1.1.1.1 without proxy environment variables` (or a similar denied-destination reach) despite Squid healthchecks passing | D13'); |
Collaborator
|
@copilot address review feedback |
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Contributor
Author
Contributor
|
✅ Copilot review passed with no inline comments. @copilot Add the |
Contributor
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (2 files)
✨ New Files (1 files)
Coverage comparison generated by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the Docker sbx fail-closed egress signature that occurs when the long-lived
sbx daemonrestarts without AWF’s Squid proxy configuration, despite healthy Squid checks.Runner-doctor catalog
Quick lookup
1.1.1.1without proxy variables to D13.Regression coverage