-
Notifications
You must be signed in to change notification settings - Fork 454
fix: emit sbx credential refresh step before agent execution #45146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+59
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -131,6 +131,25 @@ func generateDockerSbxAuthAndDaemonStep() GitHubActionStep { | |
| }) | ||
| } | ||
|
|
||
| // generateDockerSbxCredentialRefreshStep creates a step that re-authenticates the | ||
| // sbx daemon with Docker Hub immediately before AWF runs the agent. OAuth tokens | ||
| // obtained by `sbx login` during the daemon-setup step can expire or be invalidated | ||
| // by the policy-reset cycle, so a fresh login right before execution prevents | ||
| // "user is not authenticated to Docker" errors when AWF calls `sbx create`. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clear doc comment explaining why the token can expire — helpful context for future maintainers. |
||
| func generateDockerSbxCredentialRefreshStep() GitHubActionStep { | ||
| return GitHubActionStep([]string{ | ||
| " - name: Refresh sbx credentials", | ||
| " env:", | ||
| " DOCKER_PAT_VAL: ${{ secrets.DOCKER_PAT }}", | ||
| " DOCKER_USERNAME_VAL: ${{ secrets.DOCKER_USERNAME }}", | ||
| " run: |", | ||
| ` # Re-authenticate sbx immediately before AWF runs.`, | ||
| ` # Docker Hub OAuth tokens from sbx login can expire between steps.`, | ||
| ` printf '%s' "$DOCKER_PAT_VAL" | sbx login --username "$DOCKER_USERNAME_VAL" --password-stdin`, | ||
| ` echo "✅ sbx credentials refreshed"`, | ||
| }) | ||
| } | ||
|
|
||
| // generateDockerSbxPreFlightStep creates a step that verifies the sbx stack works | ||
| // end-to-end before the MCP gateway and AWF container setup begins. | ||
| func generateDockerSbxPreFlightStep() GitHubActionStep { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice — gating the credential refresh on isDockerSbxRuntime keeps this cleanly scoped to the docker-sbx runtime. 👍