Prevent rejected issue-intent closes from bypassing review by Copilot · Pull Request #64778 · github/gh-aw

Copilot · 2026-10-01T14:11:48Z

A rejected issue-intent close previously fell through to a plain issue update, potentially closing the issue without the configured review. Duplicate-close validation failures could trigger this bypass.

Fallback boundary: Fail the item when the intent request is rejected or otherwise fails. Retain the legacy fallback only for HTTP 404 or 501, which may indicate the intent endpoint is unavailable.
Regression coverage: Cover rejected requests and endpoint-unavailable fallback.

Canonical-issue metadata for duplicate intents and the failing markAsDuplicate mutation remain separate follow-ups.

Fixes close-issue: intent-path failures silently fall back to an unreviewed legacy close #64443

pr-sous-chef

Branch refresh requested by PR Sous Chef in run https://github.com/github/gh-aw/actions/runs/36880336135

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 33.6 AIC · ⌖ 8.56 AIC · ⊞ 9.2K · ◷
_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-10-01T14:26:29Z

@copilot update spec

github-actions · 2026-10-01T14:27:01Z

✅ PR Code Quality Reviewer completed the code quality review.

No GitHub write emitted yet; probing CLI invocation path only.

🔎 Code quality review by PR Code Quality Reviewer

github-actions · 2026-10-01T14:27:02Z

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch test file diff

🧪 Test quality analysis by Test Quality Sentinel

github-actions · 2026-10-01T14:27:02Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

github-actions · 2026-10-01T14:27:03Z

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

No ADR enforcement needed: PR does not have the implementation label and has <=100 new lines of code in business logic directories.

🏗️ ADR gate enforced by Design Decision Gate 🏗️

github-actions · 2026-10-01T14:27:16Z

✅ Ponytail Reviewer completed successfully!

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Generated by Ponytail Reviewer for #64778

Copilot

Copilot review overview

🟢 Approval recommended

The fallback boundary matches the stated security requirement and is covered by focused regression tests.

Review effort: Balanced
Findings: None

What changed in this PR

Prevents failed issue-intent closes from bypassing review through the legacy close path.

Changes:

Restricts legacy fallback to HTTP 404/501 responses.
Adds regression coverage for rejected and unavailable intent endpoints.

File	Description
`actions/setup/js/close_issue.cjs`	Fails closed for non-availability errors.
`actions/setup/js/close_issue.test.cjs`	Tests rejection and fallback behavior.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

github-actions · 2026-10-01T14:32:42Z

Comment Memory

reviewed_at: 2026-10-01T14:28:41Z
review_event: REQUEST_CHANGES
top_themes:
  - error-status normalization on compatibility fallback
files_reviewed:
  - actions/setup/js/close_issue.cjs
  - actions/setup/js/close_issue.test.cjs
comment_count: 1

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt54 · 29.5 AIC · ⌖ 7.14 AIC · ⊞ 20.2K · ◷
_{Comment /review to run again}

github-actions

Request changes

The compatibility fallback is still too brittle: it only recognizes top-level error.status, so wrapped 404/501 request failures can bypass the legacy path and break closes on the servers this patch is meant to protect.

Blocking theme

Normalize the HTTP status check to inspect response.status before error.status, and add a regression test for the wrapped-error shape so the fallback boundary stays pinned.

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt54 · 29.5 AIC · ⌖ 7.14 AIC · ⊞ 20.2K
_{Comment /review to run again}

github-actions · 2026-10-01T14:32:45Z

      });
      return issue;
    } catch (error) {
+      const status = error && typeof error === "object" && "status" in error ? error.status : undefined;


This only checks error.status, so wrapped 404/501 request failures will rethrow instead of taking the legacy fallback.

💡 Why this matters

Elsewhere in this repo we normalize HTTP failures with response.status before falling back to error.status because some request wrappers only populate the nested field. If the intent endpoint is unavailable in that shape, this change regresses closes back into hard failures on the older or partially deployed servers it is meant to protect. Please normalize both fields here and add a regression test for a wrapped 404 response.

Fixed in 4841a79: the close handler now checks response.status before error.status, and the regression test covers a wrapped 404 fallback.

github-actions

Skills-Based Review 🧠

Applied /diagnosing-bugs and /tdd — no actionable issues found.

📋 Analysis

Root cause fix

The bug (rejected issue-intent closes silently falling back to a plain issues.update) is fixed at its root: the catch block in closeIssue (close_issue.cjs:183-187) now re-throws unless the error status is 404 or 501, which are the only cases that genuinely indicate the intent endpoint is unavailable. All other statuses (e.g. validation rejection, server error) now correctly propagate and fail the operation instead of silently bypassing review via the legacy path.

Regression coverage

The two new it.each blocks in close_issue.test.cjs exercise both branches precisely:

403/422/500 → confirms update is never called and the original error message surfaces in result.error
404/501 → confirms the legacy fallback still fires

Test names read as clear specifications, and each asserts both the outcome (result.success) and the side effect (updateCalled), which is exactly the kind of regression-proofing /diagnosing-bugs calls for — the fix is paired with tests that would have caught the original bypass.

Minor, non-blocking observation

The inline status extraction (error && typeof error === "object" && "status" in error ? error.status : undefined) duplicates a pattern that several other files in this codebase (daily_aic_scan.cjs, set_issue_type.cjs, update_pull_request.cjs) have already factored into a shared getErrorStatus(error) helper. Not blocking — the inline form matches other recent call sites (approve_workflow_run.cjs, create_pull_request.cjs) too — but worth considering for a future cleanup pass if this pattern keeps spreading.

Positive highlights

✅ Narrow, surgical fix scoped exactly to the reported bypass
✅ Clear PR description with explicit fallback-boundary rationale
✅ No unrelated changes

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet50 · 39.5 AIC · ⌖ 14.3 AIC · ⊞ 10K
_{Comment /matt to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-10-01T14:39:02Z

@copilot update spec

Updated the safe-outputs specification to document fail-closed issue-intent close behavior, with legacy fallback limited to HTTP 404/501. Published in commit 6f580df.

gh-aw-bot · 2026-10-01T14:54:09Z

pr-sous-chef
@copilot this PR still needs forward progress before a maintainer can investigate efficiently.

Please address the outstanding review feedback, then run the pr-finisher skill.

Outstanding review feedback

github-actions: Prevent rejected issue-intent closes from bypassing review #64778 (review)

Failed checks to address

PR Code Quality Reviewer: https://github.com/github/gh-aw/actions/runs/36876205785

A branch refresh was also requested by PR Sous Chef in this run.

Generated by 👨🍳 PR Sous Chef

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 24.3 AIC · ⌖ 8.45 AIC · ⊞ 9.7K · ◷
_{Comment /souschef to run again}

gh-aw-bot · 2026-10-01T15:04:14Z

pr-sous-chef
@copilot this PR still needs forward progress before a maintainer can investigate efficiently.

Please address the outstanding review feedback, branch refresh, and then run the pr-finisher skill.

Outstanding review feedback

github-actions: Prevent rejected issue-intent closes from bypassing review #64778 (review)

A branch refresh was also requested by PR Sous Chef in this run.

Generated by 👨🍳 PR Sous Chef

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 33.6 AIC · ⌖ 8.56 AIC · ⊞ 9.2K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-10-01T15:14:15Z

pr-sous-chef
@copilot this PR still needs forward progress before a maintainer can investigate efficiently.
...

Addressed in 4841a79: wrapped HTTP status handling and its 404 regression test are committed and pushed. The cited workflow run completed without failed jobs; the review finding was the blocker. The branch is current with main; local checks pass. The PR remains blocked pending maintainer review, and CI must be re-triggered after this push.

Copilot · 2026-10-01T15:23:45Z

pr-sous-chef
@copilot this PR still needs forward progress before a maintainer can investigate efficiently.
...

The review finding was fixed and answered in 4841a79, including a wrapped-404 regression test. I fetched main; this branch is current (0 commits behind), so no refresh merge was needed. The review thread is outdated but remains unresolved; this environment has no thread-resolution control.

pelikhan · 2026-10-01T15:32:11Z

@copilot add logging (privacy preserving)

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-10-01T15:49:03Z

@copilot add logging (privacy preserving)

Added attempt, success, rejection, and fallback diagnostics in actions/setup/js/close_issue.cjs. The logs avoid issue content and raw exception text; tests confirm the emitted diagnostics are sanitized. Committed as f183092.

pr-sous-chef
@copilot this PR still needs forward progress before a maintainer can investigate efficiently.
...

The branch-refresh check confirmed the branch is current with main, so no merge was needed. The prior review finding was fixed in 4841a79; run 36876205785 completed with no failed jobs. The final local validation gate passed, including all 76 issue-close tests, and privacy-safe logging is pushed in f183092. CI for the new head still needs a maintainer-triggered run.

github-actions · 2026-10-03T01:45:03Z

🎉 This pull request is included in a new release.

Release: v0.90.3

Initial plan

6b9c6a0

Copilot AI assigned Copilot and pelikhan Oct 1, 2026

Copilot AI linked an issue Oct 1, 2026 that may be closed by this pull request

close-issue: intent-path failures silently fall back to an unreviewed legacy close #64443

Closed

Copilot started work on behalf of pelikhan October 1, 2026 14:12 View session

Fail rejected issue-intent closes instead of bypassing review

cb0a3fa

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix intent-path failures in close-issue~~ Prevent rejected issue-intent closes from bypassing review Oct 1, 2026

Copilot finished work on behalf of pelikhan October 1, 2026 14:20

Copilot AI requested a review from pelikhan October 1, 2026 14:20

pelikhan marked this pull request as ready for review October 1, 2026 14:25

Copilot AI balanced review requested due to automatic review settings October 1, 2026 14:25

Copilot started reviewing on behalf of pelikhan October 1, 2026 14:25 View session

github-actions Bot mentioned this pull request Oct 1, 2026

[aw] Ponytail Reviewer produced no safe outputs #64652

Closed

github-actions Bot added the needs-review label Oct 1, 2026

Copilot AI reviewed Oct 1, 2026

View reviewed changes

Copilot started work on behalf of pelikhan October 1, 2026 14:32 View session

github-actions Bot requested changes Oct 1, 2026

View reviewed changes

github-actions Bot approved these changes Oct 1, 2026

View reviewed changes

Document issue-intent close fallback boundary

6f580df

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan October 1, 2026 14:39

github-actions Bot mentioned this pull request Oct 1, 2026

[pr-sous-chef] PR Sous Chef run report #64600

Closed

Copilot started work on behalf of gh-aw-bot October 1, 2026 14:54 View session

Handle wrapped issue-intent HTTP errors

4841a79

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot October 1, 2026 15:14

Copilot AI requested a review from gh-aw-bot October 1, 2026 15:14

Copilot started work on behalf of gh-aw-bot October 1, 2026 15:15 View session

Copilot finished work on behalf of gh-aw-bot October 1, 2026 15:24

Copilot started work on behalf of pelikhan October 1, 2026 15:33 View session

Add privacy-safe issue intent logging

f183092

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan October 1, 2026 15:50

pelikhan merged commit a74f516 into main Oct 1, 2026
3 checks passed

pelikhan deleted the copilot/close-issue-failures-fallback branch October 1, 2026 15:56

Conversation

Copilot AI commented Oct 1, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pelikhan commented Oct 1, 2026

Uh oh!

github-actions Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

github-actions Bot commented Oct 1, 2026

Comment Memory

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Request changes

Uh oh!

github-actions Bot Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Root cause fix

Regression coverage

Minor, non-blocking observation

Positive highlights

Uh oh!

Copilot AI commented Oct 1, 2026

Uh oh!

gh-aw-bot commented Oct 1, 2026

Outstanding review feedback

Failed checks to address

Uh oh!

gh-aw-bot commented Oct 1, 2026

Outstanding review feedback

Uh oh!

Copilot AI commented Oct 1, 2026

Uh oh!

Copilot AI commented Oct 1, 2026

Uh oh!

pelikhan commented Oct 1, 2026

Uh oh!

Copilot AI commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Oct 1, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Oct 1, 2026 •

edited

Loading

github-actions Bot commented Oct 1, 2026 •

edited

Loading

github-actions Bot commented Oct 1, 2026 •

edited

Loading

github-actions Bot commented Oct 1, 2026 •

edited

Loading

github-actions Bot commented Oct 1, 2026 •

edited

Loading

Copilot AI commented Oct 1, 2026 •

edited

Loading