Skip to content

fix(notifications): set destructiveHint false on subscription tools #2845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
syf2211 wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −4
Open

fix(notifications): set destructiveHint false on subscription tools #2845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/github/__toolsnaps__/manage_notification_subscription.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"annotations": {
"destructiveHint": false,
"idempotentHint": false,
"readOnlyHint": false,
"title": "Manage notification subscription"
Expand Down
1 change: 1 addition & 0 deletions pkg/github/__toolsnaps__/manage_repository_notification_subscription.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"annotations": {
"destructiveHint": false,
"idempotentHint": false,
"readOnlyHint": false,
"title": "Manage repository notification subscription"
Expand Down
10 changes: 6 additions & 4 deletions pkg/github/notifications.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,8 +413,9 @@ func ManageNotificationSubscription(t translations.TranslationHelperFunc) invent
Name: "manage_notification_subscription",
Description: t("TOOL_MANAGE_NOTIFICATION_SUBSCRIPTION_DESCRIPTION", "Manage a notification subscription: ignore, watch, or delete a notification thread subscription."),
Annotations: &mcp.ToolAnnotations{
Title: t("TOOL_MANAGE_NOTIFICATION_SUBSCRIPTION_USER_TITLE", "Manage notification subscription"),
ReadOnlyHint: false,
Title: t("TOOL_MANAGE_NOTIFICATION_SUBSCRIPTION_USER_TITLE", "Manage notification subscription"),
ReadOnlyHint: false,
DestructiveHint: jsonschema.Ptr(false),
},
InputSchema: &jsonschema.Schema{
Type: "object",
Expand Down Expand Up @@ -509,8 +510,9 @@ func ManageRepositoryNotificationSubscription(t translations.TranslationHelperFu
Name: "manage_repository_notification_subscription",
Description: t("TOOL_MANAGE_REPOSITORY_NOTIFICATION_SUBSCRIPTION_DESCRIPTION", "Manage a repository notification subscription: ignore, watch, or delete repository notifications subscription for the provided repository."),
Annotations: &mcp.ToolAnnotations{
Title: t("TOOL_MANAGE_REPOSITORY_NOTIFICATION_SUBSCRIPTION_USER_TITLE", "Manage repository notification subscription"),
ReadOnlyHint: false,
Title: t("TOOL_MANAGE_REPOSITORY_NOTIFICATION_SUBSCRIPTION_USER_TITLE", "Manage repository notification subscription"),
ReadOnlyHint: false,
DestructiveHint: jsonschema.Ptr(false),
},
InputSchema: &jsonschema.Schema{
Type: "object",
Expand Down
6 changes: 6 additions & 0 deletions pkg/github/notifications_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,9 @@ func Test_ManageNotificationSubscription(t *testing.T) {

assert.Equal(t, "manage_notification_subscription", tool.Name)
assert.NotEmpty(t, tool.Description)
require.NotNil(t, tool.Annotations)
require.NotNil(t, tool.Annotations.DestructiveHint)
assert.False(t, *tool.Annotations.DestructiveHint)

schema, ok := tool.InputSchema.(*jsonschema.Schema)
require.True(t, ok, "InputSchema should be *jsonschema.Schema")
Expand Down Expand Up @@ -282,6 +285,9 @@ func Test_ManageRepositoryNotificationSubscription(t *testing.T) {

assert.Equal(t, "manage_repository_notification_subscription", tool.Name)
assert.NotEmpty(t, tool.Description)
require.NotNil(t, tool.Annotations)
require.NotNil(t, tool.Annotations.DestructiveHint)
assert.False(t, *tool.Annotations.DestructiveHint)

schema, ok := tool.InputSchema.(*jsonschema.Schema)
require.True(t, ok, "InputSchema should be *jsonschema.Schema")
Expand Down
Loading