Fix Xojo.gitignore exclusion of Builds folder - #4893
Open
travisjhicks wants to merge 1 commit into
Open
Conversation
- The “Builds” folder pattern would match source code files starting with “Builds”. Corrected to only match directories with Xojo’s Builds folder naming convention. - Removed blank line between comment heading and patterns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to the application or project's homepage
https://www.xojo.com
Reasons for making this change
Xojo is only compiled through the Xojo IDE. The Xojo IDE writes compiled output to a directory of the form
Builds - [Project Name]. The previous rule ofBuilds*can match source code files such asBuildsManager.xojo_code. It makes more sense to use a more specific pattern limited to directories.I also removed the blank line between the comment header and the patterns.
Links to documentation supporting these rule changes
A getting started tutorial...
https://documentation.xojo.com/getting_started/tutorials/desktop_tutorial.html#:~:text=In%20the%20folder,for%20each%20platform
...makes reference to the naming convention of the Builds folder for compiled output...
Merge and Approval Steps