-
Notifications
You must be signed in to change notification settings - Fork 10.6k
feat(workflows): align workflow CLI with extension command surface #3419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marcelsafin
wants to merge
59
commits into
github:main
Choose a base branch
from
marcelsafin:feat/2342-workflow-cli-alignment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
bba88bb
feat(workflows): align workflow CLI with extension command surface
marcelsafin cc8143e
fix(workflows): preserve disabled state on update, guard corrupted re…
marcelsafin 59a791b
fix(workflows): guard list against corrupted registry entries, re-rai…
marcelsafin 52ab7ff
fix(workflows): escape rich markup in id-mismatch errors and validate…
marcelsafin 4c356c4
fix(workflows): escape rich markup in list output and catalog install…
marcelsafin 8409bca
fix(workflows): escape rich markup in --from download exception message
marcelsafin 129362f
fix(workflows): catch OSError in per-workflow update loop and make re…
marcelsafin 4ca50f5
fix(workflows): escape rich markup in search output
marcelsafin 10f9770
fix: escape workflow validation errors before Rich output
marcelsafin 91c7165
fix(workflows): escape remaining unescaped Rich markup paths
marcelsafin 7100211
fix(workflows): escape workflow name/id in install success messages
marcelsafin a530725
fix(workflows): fail cleanly on unparseable catalog install URLs
marcelsafin 560c7cd
fix(workflows): reject catalog updates whose downloaded version misma…
marcelsafin e44d214
fix(workflows): validate workflow ID in run command and document new …
marcelsafin 8efa3c0
fix(workflows): enforce disabled state for direct paths to installed …
marcelsafin 96d3b38
fix(workflows): reject explicit empty --from URL instead of catalog f…
marcelsafin f28e125
fix(workflows): registry rollback on save failure, consistent disable…
marcelsafin 338f7ee
fix(workflows): guard non-string catalog URL and keep enable/disable …
marcelsafin 82ecd05
fix(workflows): tolerate non-dict registry entries in add and clarify…
marcelsafin 6b25c75
fix(workflows): atomic registry save and accurate mixed-target update…
marcelsafin eabce4e
fix(workflows): exclusive temp file for registry save and cwd-indepen…
marcelsafin cac5300
fix(workflows): symlink guards and shape validation in workflow regis…
marcelsafin a69bb18
fix(workflows): validate download redirects before following them
marcelsafin 6a0c462
test(workflows): accept redirect_validator kwarg in step-add open_url…
marcelsafin 3763e6f
fix(workflows): guard directory-shaped workflow.yml and unreadable re…
marcelsafin 86de599
fix(workflow): rollback registry.remove() and guard OSError at CLI bo…
marcelsafin fb64ddd
fix(workflow): preserve prior catalog install on reinstall registry-s…
marcelsafin 49f6fb6
fix(workflow): centralize catalog-install cleanup across all failure …
marcelsafin 812050a
fix(workflow): restore registry entry verbatim on post-removal rmtree…
marcelsafin 6a127b3
Fix 4 current Copilot review findings on workflow run/registry/install
marcelsafin 12d985b
Fix disabled-workflow bypass via symlinked .specify project root
marcelsafin ce3e0ab
Fix raw exception leak in bundle remove primitive boundary
marcelsafin 6b593e3
Fix 8 current Copilot review findings on registry fail-closed, rollba…
marcelsafin db45f6c
Fix 3 current Copilot review findings: bookkeeping-aware BundlerError…
marcelsafin b8269c8
Fix temp-file leak in workflow add --from and strengthen size-limit t…
marcelsafin 00465c3
Harden workflow install/remove transactions with atomic staging
marcelsafin 7c6bc90
Discard reinstall backup file after registry.add() succeeds
marcelsafin 915caf8
Clean up freshly-created dest_dir when staging mkstemp fails
marcelsafin 792450e
Fix installed-workflow ownership/disabled bypass and resume enforcement
marcelsafin 800b962
Guard --from temp cleanup; drop redundant update rollback; mark POSIX…
marcelsafin 616f727
Report possible partial changes on zero-removed bundle removal failure
marcelsafin 4f24735
Fix workflow resume disabled-check bypass after project move/rename
marcelsafin fa410d3
Fix silenced cleanup failures and malformed run-state type validation
marcelsafin 8e69966
Add ValueError boundary to workflow status single-run lookup
marcelsafin a837fb5
fix: bound workflow step downloads
marcelsafin db67e96
fix: preserve workflow reinstall state
marcelsafin a874b97
fix: fail closed on workflow registry state
marcelsafin c098d86
fix: make workflow installs transactional
marcelsafin e799957
fix: close workflow transaction races
marcelsafin d964c97
fix: clean up failed workflow transactions
marcelsafin 6b968ef
fix: clean up workflow removal state
marcelsafin c82e214
fix: guard workflow update transactions
marcelsafin 26551ae
fix: harden workflow lifecycle edge cases
marcelsafin ec53251
fix: verify installed workflow ownership
marcelsafin 77116a1
fix: isolate workflow rollback cleanup
marcelsafin 8f795a6
fix: preserve unique workflow backups
marcelsafin da86926
fix: bind workflow staging to file descriptors
marcelsafin 2c47c86
fix: fail closed on corrupt workflow registry
marcelsafin 5163aa2
fix: bind workflow ownership and source identity
marcelsafin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.