feat: support to install docker compose as docker CLI plugins#31
Open
prakasa1904 wants to merge 2 commits into
Open
feat: support to install docker compose as docker CLI plugins#31prakasa1904 wants to merge 2 commits into
prakasa1904 wants to merge 2 commits into
Conversation
githubixx
requested changes
May 13, 2026
Owner
githubixx
left a comment
There was a problem hiding this comment.
Thanks for the PR! I've merged a new version which already contains handling python3-apt e.g. Please update your PR accordingly. Then I can have a second look.
| # - standalone: The standalone "docker-compose" binary. This is the old way to use "docker-compose". The binary is called "docker-compose" and is installed in a directory defined by `docker_compose_bin_directory` variable. This is the default value for `docker_compose_type` variable. | ||
| # - plugin: The "docker compose" plugin for "docker" CLI. This is the new way to use "docker-compose". The binary is called "docker-compose" and is installed in "/usr/local/lib/docker/cli-plugins/docker-compose". This is the recommended way to use "docker-compose" and is the default value for `docker_compose_type` variable. | ||
| # When commented no "docker-compose" will be installed and all "docker_compose_*" variables will be ignored. | ||
| docker_compose_type: "plugin" |
Owner
There was a problem hiding this comment.
Suggested change
| docker_compose_type: "plugin" | |
| docker_compose_type: "standalone" |
Otherwise this would change the current default and I'm not a big fan of changing defaults as people are not expecting such changes normally. I guess that might make sense for the next major release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding features to install docker-compose in 2 kind versions:
docker-compose.docker compose