refactor(audit): reduce complexity of add_ado_proxy_findings in src/audit/findings.rs

[github-actions]

Summary

Clippy's too_many_lines lint flagged add_ado_proxy_findings in src/audit/findings.rs at 219/100 lines. The function was a single long sequence of seven independent if-blocks, each checking a different ado-proxy failure/policy signal (unhealthy lifecycle, unavailable credential, upstream failures, out-of-scope responses, prompt/policy conflicts, prohibited requests, malformed decision records) and pushing a matching Finding + Recommendation.

Change

Extracted each of the seven blocks into its own single-purpose helper function (e.g. add_ado_proxy_unhealthy_lifecycle_finding, add_ado_proxy_credential_unavailable_finding, ...), each taking &AdoProxyAnalysis plus the shared findings/recommendations vectors and early-returning when its condition does not apply. add_ado_proxy_findings now just calls each helper in the original order.

No behavioral change — the same findings and recommendations are produced in the same order for the same inputs, and the public API (derive_findings) is unchanged.

Verification

• cargo build — passes
• cargo test --bin ado-aw audit:: — 154 tests pass, including all audit::findings::tests::*
• cargo clippy --all-targets --all-features — clean
• Re-ran cargo clippy -- -W clippy::too_many_lines scoped to this file — no more warning for add_ado_proxy_findings

Before: this function has too many lines (219/100)
After: no too_many_lines warning remains for add_ado_proxy_findings

Generated by Cyclomatic Complexity Reducer · auto · 90.5 AIC · ⌖ 15.9 AIC · ⊞ 9.7K · ◷

[azure-pipelines]

Azure Pipelines:
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[jamesadevine]

The same audit findings refactor was already merged through #2189; #2238 records this duplicate disposition. Closing as superseded.