refactor(sonar): resolve nested ternary operators (typescript:S3358)

src/main/handlers/tray.ts

@@ -21,13 +21,14 @@ export function registerTrayHandlers(mb: Menubar): void {
       return;
     }
     const { notificationsCount, isOnline } = status;
-    const icon = !isOnline
-      ? TrayIcons.offline
-      : notificationsCount < 0
-        ? TrayIcons.error
-        : notificationsCount > 0 && highlightUnread
-          ? TrayIcons.active
-          : getIdleTrayIcon(appearance);
+    let icon = getIdleTrayIcon(appearance);
+    if (!isOnline) {
+      icon = TrayIcons.offline;
+    } else if (notificationsCount < 0) {
+      icon = TrayIcons.error;
+    } else if (notificationsCount > 0 && highlightUnread) {
+      icon = TrayIcons.active;
+    }
     mb.tray.setImage(icon);
   };
 

src/renderer/components/settings/SystemSettings.tsx

@@ -121,6 +121,11 @@ export const SystemSettings: FC = () => {
   const hasLiveModifiers = liveModifierAccelerator.length > 0;
   const liveModifierDisplay = formatAcceleratorForDisplay(liveModifierAccelerator, isMac);
 
+  let shortcutButtonLabel = shortcutDisplay;
+  if (recordingShortcut) {
+    shortcutButtonLabel = hasLiveModifiers ? `${liveModifierDisplay}…` : 'Press keys…';
+  }
+
   return (
     <fieldset>
       <Title icon={DeviceDesktopIcon}>System</Title>
@@ -237,11 +242,7 @@ export const SystemSettings: FC = () => {
               tabIndex={-1}
             >
               <Text as="strong" className="text-gitify-caution">
-                {recordingShortcut
-                  ? hasLiveModifiers
-                    ? `${liveModifierDisplay}…`
-                    : 'Press keys…'
-                  : shortcutDisplay}
+                {shortcutButtonLabel}
               </Text>
             </Button>
             <IconButton

src/renderer/routes/Accounts.tsx

@@ -38,6 +38,16 @@
 import { openAccountProfile, openAccountSettings, openHost } from '../utils/system/links';
 import { getPlatformIcon } from '../utils/ui/icons';
 
+function getScopeIconClassName(account: Account): string {
+  if (hasRecommendedScopes(account)) {
+    return IconColor.GREEN;
+  }
+  if (hasAlternateScopes(account)) {
+    return 'text-gitify-warning';
+  }
+  return '';
+}
+
 export const AccountsRoute: FC = () => {
   const navigate = useNavigate();
 
@@ -232,17 +242,7 @@
                       <IconButton
                         aria-label={`View scopes for ${account.user?.login}`}
                         data-testid="account-view-scopes"
-                        icon={() => (
-                          <ShieldCheckIcon
-                            className={
-                              hasRecommendedScopes(account)
-                                ? IconColor.GREEN
-                                : hasAlternateScopes(account)
-                                  ? 'text-gitify-warning'
-                                  : ''
-                            }
-                          />
-                        )}
+                        icon={() => <ShieldCheckIcon className={getScopeIconClassName(account)} />}
                         onClick={() =>
                           navigate('/account-scopes', {
                             state: { account },

src/renderer/stores/useAccountsStore.ts

@@ -109,13 +109,12 @@ const useAccountsStore = create<AccountsStore>()(
           );
 
           set({
-            accounts: accounts.flatMap((account, index) =>
-              replacesAccount(account)
-                ? index === existingAccountIndex
-                  ? [newAccount]
-                  : []
-                : [account],
-            ),
+            accounts: accounts.flatMap((account, index) => {
+              if (!replacesAccount(account)) {
+                return [account];
+              }
+              return index === existingAccountIndex ? [newAccount] : [];
+            }),
           });
         } else {
           set({ accounts: [...accounts, newAccount] });

src/renderer/stores/useSettingsStore.ts

@@ -1,6 +1,8 @@
 import { create } from 'zustand';
 import { persist, subscribeWithSelector } from 'zustand/middleware';
 
+import type { TrayIconAppearance } from '../../shared/events';
+
 import { Constants } from '../constants';
 
 import type { SettingsStore } from './types';
@@ -49,15 +51,16 @@ const useSettingsStore = create<SettingsStore>()(
             useAlternateIdleIcon: undefined,
             ...persisted,
           };
+          let trayIconAppearance: TrayIconAppearance = 'auto';
+          if (useAlternateIdleIcon === true) {
+            trayIconAppearance = 'light';
+          } else if (useAlternateIdleIcon === false && !window.gitify.platform.isMacOS()) {
+            trayIconAppearance = 'dark';
+          }
           return {
             ...DEFAULT_SETTINGS_STATE,
             ...settings,
-            trayIconAppearance:
-              useAlternateIdleIcon === true
-                ? 'light'
-                : useAlternateIdleIcon === false && !window.gitify.platform.isMacOS()
-                  ? 'dark'
-                  : 'auto',
+            trayIconAppearance,
           };
         },
       },

src/renderer/utils/system/keyboardShortcut.ts

@@ -91,7 +91,10 @@ export function formatAcceleratorForDisplay(accelerator: string, isMac: boolean)
     .split('+')
     .map((segment) => {
       const entry = MODIFIER_SEGMENTS.find((m) => m.accelerator === segment);
-      return entry ? (isMac ? entry.mac : entry.other) : segment;
+      if (!entry) {
+        return segment;
+      }
+      return isMac ? entry.mac : entry.other;
     })
     .join(isMac ? '·' : '+');
 }