Skip to content

test: replace deprecated settings assertion - #3397

Merged
setchy merged 1 commit into
mainfrom
test/sonar-settings-assertion
Oct 9, 2026
Merged

setchy merged 1 commit into
mainfrom
test/sonar-settings-assertion

Conversation

@setchy

@setchy setchy commented Oct 8, 2026

Copy link
Copy Markdown
Member

Summary

Replace Vitest's deprecated toThrowError matcher with supported toThrow in useSettingsStore.test.ts, preserving the existing error-message assertion.

Addresses the sonarjs/deprecation finding from the one-off test-code scan. Only this test file changes; no production behavior, dependencies, or configuration changes.

Validation

  • Focused settings-store suite: 18 tests passed.
  • Full suite: 1,865 tests passed across 186 files.
  • TypeScript, formatting/lint checks, and production build passed. The build emitted a non-fatal chunk-size warning.
  • Type-aware SonarJS recommended-rule scan of the changed file: zero findings and zero parsing errors. This is a local ESLint-plugin result, not a claim about SonarCloud issue closure.

@setchy
setchy requested a review from afonsojramos as a code owner October 8, 2026 23:58
@github-actions github-actions Bot added the test Enhancements to test coverage or quality label Oct 8, 2026
@sonarqubecloud

sonarqubecloud Bot commented Oct 9, 2026

Copy link
Copy Markdown

@setchy
setchy merged commit 00acc8f into main Oct 9, 2026
19 checks passed
@setchy
setchy deleted the test/sonar-settings-assertion branch October 9, 2026 00:03
@github-actions github-actions Bot added this to the Release 7.10.0 milestone Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Enhancements to test coverage or quality

Development

Successfully merging this pull request may close these issues.

1 participant