Repository navigation
refactor(renderer): relocate shortcut-registration store into stores - #3411
Merged
Merged
Conversation
Move the transient global-shortcut registration Zustand store out of the hooks layer into the stores layer, matching the documented state-ownership rule for session client state. - Add stores/useShortcutRegistrationStore.ts and mirror its ShortcutRegistrationStore type in stores/types.ts - Export it from the stores barrel - Trim hooks/useShortcutRegistration.ts to the effect hook, importing the store from the stores layer - Repoint the seven consumers (GlobalEffects, SystemSettings, and the test setup/helpers) to the barrel No behavior change: registration, revert-on-failure, and the surfaced error are identical.
setchy
force-pushed
the
refactor/relocate-shortcut-registration-store
branch
from
October 14, 2026 10:48
458df2b to
9e08708
Compare
|
Contributor
|
🎉 This pull request is included in Gitify v7.10.0! 🎉 Downloads for macOS, Windows, and Linux are available on the release page. Thanks for helping make Gitify better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relocates the transient global-shortcut registration store from the
hookslayer into thestoreslayer, so it matches the renderer's documented state-ownership rule (session client state belongs tostores).stores/useShortcutRegistrationStore.tsand mirrors itsShortcutRegistrationStoretype instores/types.ts; exports it from the stores barrel.hooks/useShortcutRegistration.tsis now just the effect hook and imports the store fromstores/.GlobalEffects,SystemSettings, and the test setup/helpers).No behavior change: registration, revert-on-failure, and the surfaced error are identical.
Verification
tsc --noEmit— cleanpnpm check(format + lint) — cleanpnpm test— 186 files, 1884 tests passing