Repository navigation
refactor(sonar): mark component props as read-only (typescript:S6759) - #3448
Merged
Merged
Conversation
|
Contributor
|
🎉 This pull request is included in Gitify v7.10.0! 🎉 Downloads for macOS, Windows, and Linux are available on the release page. Thanks for helping make Gitify better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SonarCloud rule
typescript:S6759("React props should be read-only") flags every function component whosepropsparameter is typed with a mutable object type. Marking props as read-only documents intent, prevents accidental mutation inside a component, and lets TypeScript catch reassignment.Changes
Wrap each flagged component's
propsparameter type inReadonly<…>— 46 signatures across 44 files:src/renderer/components/**—AllRead,Oops,AvatarWithFallback,FieldLabel,RadioGroup,Tooltip,FilterSection,SearchFilterSuggestions,TokenSearchInput, layout (AppLayout,Centered,Contents,EmojiSplash,Page),LoginWithPersonalAccessTokenForm, every metric pill, the notification components, and the primitives (CustomCounter,EmojiText,Footer,Header,HoverGroup,Title).src/renderer/icons/**—BitbucketIcon,GitLabIcon,LogoIcon,ScopeStatusIcon.src/renderer/routes/Accounts.tsx—RecommendedScopesIcon,AlternateScopesIcon.Type-only refactor; no runtime behaviour changes.
Verification
pnpm check(oxlint + oxfmt +tsc --noEmit) — passpnpm test— 190 test files / 1911 tests passedSonarCloud issues
https://sonarcloud.io/project/issues?id=gitify-app_gitify&s=IMPACT_RANK&issueStatuses=OPEN&rules=typescript%3AS6759