Repository navigation
chore(lint): prevent focused vitest tests - #3483
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Vitest lint plugin with
vitest/no-focused-testsas an error, so a committeddescribe.only/it.onlyfailspnpm checkinstead of silently reducing coverage. Vitest itself only rejects focused tests in CI (allowOnlydefaults to!process.env.CI), so this catches the mistake locally too.The plugin's other correctness rules are explicitly disabled because they would require a broad test refactor (notably
require-mock-type-parameters: 286 existing hits). Onlyno-focused-testsis opted into.Verification
describe.only(...)test is reported by the new rule.pnpm checkpasses.