Repository navigation
chore(lint): enforce forge adapter boundary - #3485
Merged
Merged
Conversation
setchy
force-pushed
the
chore/lint-forge-adapter-boundary
branch
from
October 24, 2026 13:29
9bab865 to
b58b814
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
ARCHITECTURE.mdsays shared code must go through the forge adapter (getAdapter/getAccountAdapter) rather than importing a forge-specific module directly. This enforces that.forgeSpecificBoundaryPatternbuilt withrendererBoundaryPattern.utilsoverride sosrc/renderer/utils/forges/**implementations remain allowed to import their own forge modules, while the rest ofutilsis restricted.stores,hooks,components, the notification UI,icons, and the leaf modules.routes,App.tsx, andindex.tsx.allowTypeImports: true), so the existing type-only import of generated GitHub GraphQL types still passes.Verification
utils/forges/github/clientis reported, while code underutils/forges/github/may import its own modules.pnpm checkpasses.