Skip to content

chore(lint): add import hygiene rules #3487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
setchy merged 1 commit into from
Oct 24, 2026
Merged

chore(lint): add import hygiene rules #3487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/renderer/utils/forges/github/handlers/checkSuite.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
import { mockPartialGitifyNotification } from '../../../../__mocks__/notifications-mocks';

import type { GitifyNotification } from '../../../../types';
import { type GitifyCheckSuiteStatus, IconColor, type Link } from '../../../../types';
import {
type GitifyCheckSuiteStatus,
type GitifyNotification,
IconColor,
type Link,
} from '../../../../types';

import { checkSuiteHandler, getCheckSuiteAttributes } from './checkSuite';

Expand Down
8 changes: 6 additions & 2 deletions src/renderer/utils/forges/github/handlers/default.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
import { mockPartialGitifyNotification } from '../../../../__mocks__/notifications-mocks';

import type { GitifyNotification } from '../../../../types';
import { type GitifyNotificationState, IconColor, type Link } from '../../../../types';
import {
type GitifyNotification,
type GitifyNotificationState,
IconColor,
type Link,
} from '../../../../types';

import { defaultHandler } from './default';

Expand Down
2 changes: 1 addition & 1 deletion src/renderer/utils/forges/github/handlers/discussion.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import {
noReactionGroups,
} from '../__mocks__/response-mocks';

import type { GitifyNotification } from '../../../../types';
import {
type GitifyDiscussionState,
type GitifyNotification,
type GitifySubject,
IconColor,
type Link,
Expand Down
9 changes: 7 additions & 2 deletions src/renderer/utils/forges/github/handlers/issue.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,13 @@ import {
noReactionGroups,
} from '../__mocks__/response-mocks';

import type { GitifyNotification } from '../../../../types';
import { type GitifyIssueState, type GitifySubject, IconColor, type Link } from '../../../../types';
import {
type GitifyIssueState,
type GitifyNotification,
type GitifySubject,
IconColor,
type Link,
} from '../../../../types';

import * as apiClient from '../client';
import type { FetchIssueByNumberQuery } from '../graphql/generated/graphql';
Expand Down
2 changes: 1 addition & 1 deletion src/renderer/utils/forges/github/handlers/pullRequest.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import {
noReactionGroups,
} from '../__mocks__/response-mocks';

import type { GitifyNotification } from '../../../../types';
import {
type GitifyNotification,
type GitifyPullRequestState,
type GitifySubject,
IconColor,
Expand Down
2 changes: 1 addition & 1 deletion src/renderer/utils/system/links.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { mockGitHubCloudAccount } from '../../__mocks__/account-mocks';
import {
mockBitbucketAccount,
mockGiteaAccount,
mockGitHubCloudAccount,
mockGitLabAccount,
} from '../../__mocks__/account-mocks';
import { mockGitifyNotification } from '../../__mocks__/notifications-mocks';
Expand Down
3 changes: 3 additions & 0 deletions vite.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,9 @@ export default defineConfig({
},
ignorePatterns: ['**/generated/**', 'build/**', 'dist/**', 'coverage/**', 'node_modules/**'],
rules: {
'import/no-self-import': 'error',
'import/no-duplicates': 'error',
'import/no-empty-named-blocks': 'error',
'no-console': 'error',
'no-unused-vars': [
'error',
Expand Down
Loading