Repository navigation
test: isolate test files and restore test-scoped spies - #3499
Merged
Merged
Conversation
Enable per-file isolation so module state cannot leak between test files. Add a setup that restores spies created inside a test while leaving intentional module-scope spies in place, give the notifications mock a deterministic empty default, and drop stale shared-fixture resets.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
undefinedaftermockReset().mockGitifyNotification.unreadresets; the fixture is no longer mutated by the suite.Why
isolate: falsecombined withclearMocks(which only clears calls) made test order matter. A globalrestoreMocksis not safe here because many suites intentionally share spies across tests, so the setup restores only spies created during a test.Verification
pnpm test: 200 files, 1,968 tests passedpnpm exec vp check --no-fmt: 464 files passed