Repository navigation
test: raise the default timeout and quiet browser act warnings - #3503
Merged
Merged
Conversation
Give slower renderer tests a 10s budget instead of the 5s default. Mark the browser visual environment as non-act, since Playwright drives interactions outside React's act boundary; the unit projects keep the failing act-warning gate.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testTimeoutto 10s so heavy renderer tests do not fail on the 5s default under load.Verification
pnpm test: 200 files, 1,968 tests passedscripts/visual.sh: 60 tests passed, no act warningspnpm exec vp check --no-fmt: 465 files passed