Repository navigation
test: assert notification and account state instead of styling - #3504
Merged
Merged
Conversation
Expose a stable data-animating-exit state on notification rows so visual tests stop reading the opacity utility class. Accounts scope tests now use the button's accessible name and variant, dropping the icon colour-class assertions.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-animating-exitstate to notification rows and assert that in the browser suite instead of theopacity-0utility class.data-variant; remove the icon colour-class assertions.Why
Both assertions were coupled to Tailwind implementation details. The stable state/variant attributes describe the same behaviour without breaking on styling changes. The account tests still verify the correct icon (
octicon-shield-check) and the semantic button variant.Verification
pnpm test: 200 files, 1,968 tests passedpnpm exec vp check --no-fmt: 465 files passed