Repository navigation
ci(labeler): accept breaking-change markers in PR titles - #3513
Merged
Merged
Conversation
The Semantic Pull Request status matches the PR title against the labeler config, whose patterns require type(scope): subject. A conventional-commit breaking marker (feat(auth)!:) matched no label, so breaking PRs failed the status check. Allow an optional ! in every title matcher.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Semantic Pull Requeststatus is produced by thechecksblock in.github/labeler.yml. Its title matchers expecttype(scope): subjectand do not allow the conventional-commits breaking marker, sofeat(auth)!: ...matches no label and the status fails with "Missing semantic label for merge" — as it does on #3449.This adds an optional
!to every title matcher, so breaking PRs keep their semantic label and the status check stops blocking them.Changes
!?after the type/scope in thebug,build,chore,documentation,enhancement,refactor/perf,test, andforge:*matchers.releasematcher unchanged: release-please titles are never breaking.Testing
Checked every matcher against breaking and non-breaking titles locally:
feat(auth)!:,feat!:,fix(api)!:,refactor(auth)!:,perf(renderer)!:,docs!:,build(deps)!:,test(auth)!:,chore(ci)!:forge:github,forge:bitbucket, andforge:giteascoped breaking titleschore(main): release 7.11.0All matched their intended labels. This PR's own title (
ci(labeler): ...) matches the build matcher, so its own Semantic Pull Request status should pass.Related