This repository was archived by the owner on Apr 27, 2024. It is now read-only.
Issue #73 : download settings as JSON file#74
Open
Max104t wants to merge 1 commit into
Open
Conversation
gitnew2018
reviewed
Jan 31, 2020
gitnew2018
left a comment
gitnew2018
left a comment
Owner
There was a problem hiding this comment.
Looks good so far.
I'm not going to merge it right now because when you can't import back your settings it's kinda useless to users. Also this code might be slightly modified when the rest is added as it usually happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a button to the edit settings section to allow the settings (actually all of local storage) to be downloaded for backup. the file name is formatted as
<username>-<YYYYMMDDHHMMSS>.json