Skip to content

Some gnome 50 related fixes#94

Merged
Totto16 merged 2 commits intomainfrom
some-gnome-50-related-fixes
May 1, 2026
Merged

Some gnome 50 related fixes#94
Totto16 merged 2 commits intomainfrom
some-gnome-50-related-fixes

Conversation

@Totto16
Copy link
Copy Markdown
Collaborator

@Totto16 Totto16 commented May 1, 2026

I found a small rename error in the packages/gnome-shell/src/extensions/global.d.ts file.

Also bump @Girs dependencies to the newest version (rc.8)

I would like to bump the version after this PR to 50.0.0-alpha.2 or even to 50.0.0, as I personally think, it is correct, as gnome 50 changed relatively few things and I tested it with my extension, and everything seems to be correct.

What are your thoughts @swsnr @schnz @JumpLink ?

@Totto16 Totto16 requested review from JumpLink, schnz and swsnr as code owners May 1, 2026 12:55
@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 1, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​girs/​shew-0@​0.0.0-4.0.0-rc.1 ⏵ 0.0.0-4.0.0-rc.9741009599 +1100
Updated@​girs/​mtk-18@​18.0.0-4.0.0-rc.1 ⏵ 18.0.0-4.0.0-rc.9741009697 +3100
Updated@​girs/​gnomebg-4.0@​4.0.0-4.0.0-rc.1 ⏵ 4.0.0-4.0.0-rc.9751009599 +1100
Updated@​girs/​shell-18@​18.0.0-4.0.0-rc.1 ⏵ 18.0.0-4.0.0-rc.9761009797 +5100
Updated@​girs/​gnomebluetooth-3.0@​3.0.0-4.0.0-rc.1 ⏵ 3.0.0-4.0.0-rc.976 +110095 +199 +1100
Updated@​girs/​gnomedesktop-4.0@​4.0.0-4.0.0-rc.1 ⏵ 4.0.0-4.0.0-rc.9771009599 +1100
Updated@​girs/​accountsservice-1.0@​1.0.0-4.0.0-rc.1 ⏵ 1.0.0-4.0.0-rc.9771009599 +1100
Updated@​girs/​st-18@​18.0.0-4.0.0-rc.1 ⏵ 18.0.0-4.0.0-rc.977 -11009797 +5100
Updated@​girs/​upowerglib-1.0@​1.91.1-4.0.0-rc.1 ⏵ 1.91.1-4.0.0-rc.9781009699 +2100
Updated@​girs/​meta-18@​18.0.0-4.0.0-rc.1 ⏵ 18.0.0-4.0.0-rc.9781009797 +3100
Updated@​girs/​clutter-18@​18.0.0-4.0.0-rc.1 ⏵ 18.0.0-4.0.0-rc.9801009797 +3100
Updated@​girs/​gdm-1.0@​1.0.0-4.0.0-rc.1 ⏵ 1.0.0-4.0.0-rc.9801009699 +1100
Updated@​girs/​adw-1@​1.10.0-4.0.0-rc.1 ⏵ 1.10.0-4.0.0-rc.982 +610097 +299 +1100
Addedtypescript@​6.0.3100100909990
Updatedprettier@​3.8.1 ⏵ 3.8.39010097 +196100
Updated@​girs/​gjs@​4.0.0-rc.1 ⏵ 4.0.0-rc.9100 +19100100 +1100 +3100
Updated@​girs/​gobject-2.0@​2.88.0-4.0.0-rc.1 ⏵ 2.88.0-4.0.0-rc.9100 +12100100 +4100 +3100
Updated@​girs/​atk-1.0@​2.60.0-4.0.0-rc.1 ⏵ 2.60.0-4.0.0-rc.9100 +16100100 +4100 +3100
Updated@​girs/​cogl-2.0@​2.0.0-4.0.0-rc.1 ⏵ 2.0.0-4.0.0-rc.9100 +20100100 +5100 +3100
Updated@​girs/​gcr-4@​4.4.0-4.0.0-rc.1 ⏵ 4.4.0-4.0.0-rc.9100 +20100100 +5100 +3100
Updated@​girs/​gio-2.0@​2.88.0-4.0.0-rc.1 ⏵ 2.88.0-4.0.0-rc.9100 +15100100 +5100 +3100
Updated@​girs/​giounix-2.0@​2.0.0-4.0.0-rc.1 ⏵ 2.0.0-4.0.0-rc.9100 +22100100 +5100 +3100
Updated@​girs/​glib-2.0@​2.88.0-4.0.0-rc.1 ⏵ 2.88.0-4.0.0-rc.9100 +11100100 +4100 +3100
Updated@​girs/​gtk-4.0@​4.23.0-4.0.0-rc.1 ⏵ 4.23.0-4.0.0-rc.9100 +22100100 +5100 +3100
Updated@​girs/​gvc-1.0@​1.0.0-4.0.0-rc.1 ⏵ 1.0.0-4.0.0-rc.9100 +21100100 +5100 +3100
Updated@​girs/​polkit-1.0@​1.0.0-4.0.0-rc.1 ⏵ 1.0.0-4.0.0-rc.9100 +21100100 +5100 +3100

View full report

JumpLink
JumpLink previously approved these changes May 1, 2026
Copy link
Copy Markdown
Collaborator

@JumpLink JumpLink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

swsnr
swsnr previously approved these changes May 1, 2026
Copy link
Copy Markdown
Collaborator

@swsnr swsnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead 👍

@JumpLink
Copy link
Copy Markdown
Collaborator

JumpLink commented May 1, 2026

@Totto16 rc.8 still seems to contain a bug; I’ll be releasing another version, so it might be worth waiting for rc.9

schnz
schnz previously approved these changes May 1, 2026
@Totto16
Copy link
Copy Markdown
Collaborator Author

Totto16 commented May 1, 2026

As https://github.com/gjsify/ts-for-gir/releases/tag/v4.0.0-rc.9 released, I am just going to bump the dependencies to that version, as it isn't merged yet

Waiting for https://github.com/gjsify/types/actions/runs/25220670276/job/73951822522 to finish, then I'm committing the version bumps :)

@Totto16
Copy link
Copy Markdown
Collaborator Author

Totto16 commented May 1, 2026

@Totto16 rc.8 still seems to contain a bug; I’ll be releasing another version, so it might be worth waiting for rc.9

GitHub seems to have some issues again, xD, i didn't see that comment until now🤦🏼‍♂️

- make sure all version use the "^<version>" and not "<version>" syntax, to be consistent
@Totto16 Totto16 dismissed stale reviews from schnz, swsnr, and JumpLink via 3603777 May 1, 2026 17:37
@Totto16 Totto16 force-pushed the some-gnome-50-related-fixes branch from 3ee17b1 to 3603777 Compare May 1, 2026 17:37
@Totto16 Totto16 requested a review from JumpLink May 1, 2026 20:08
@Totto16 Totto16 merged commit ecdd08a into main May 1, 2026
4 checks passed
@Totto16 Totto16 deleted the some-gnome-50-related-fixes branch May 1, 2026 20:12
@Totto16 Totto16 mentioned this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants