Simplify env var config lookups#1382
Merged
sirosen merged 1 commit intoglobus:mainfrom May 4, 2026
Merged
Conversation
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
Our env var loading code has not aged well with the advent of type checking -- it is very dynamically typed, and attempting to annotate it precisely is overly complex. Even with type overloads, the resulting helper is not properly typed in all cases, and cannot extend to new callback types gracefully. Simplify env var loading to follow some common patterns without using complex helpers. No behaviors were intentionally changed, although a TODO note was added to an odd decision to convert `""` to a default in one case.
sirosen
force-pushed
the
improve-env-var-loading
branch
from
7062fb3 to
dcfa162
Compare
m1yag1
approved these changes
May 4, 2026
Contributor
m1yag1
left a comment
m1yag1
left a comment
There was a problem hiding this comment.
Only one question about logging differences between the old and new code. This does not block approval.
| if inputenv is None: | ||
| value = os.getenv(ENVNAME_VAR, "production") | ||
| else: | ||
| log.debug(f"on lookup, default setting: {varname}={value}") |
Contributor
There was a problem hiding this comment.
In the old code, the logs explicitly flagged whether the value was "default" or "non-default". I wanted to point this out in case losing that context wasn't intentional.
Member
Author
There was a problem hiding this comment.
I considered it acceptable, since we know what the default values are anyway.
That conditional logging would have made each of these getters more complex (either they do it themselves or there's a shared logging helper), so absent a strong motivation to keep the old logging, I simplified it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our env var loading code has not aged well with the advent of type checking -- it is very dynamically typed, and attempting to annotate it precisely is overly complex. Even with type overloads, the resulting helper is not properly typed in all cases, and cannot extend to new callback types gracefully.
Simplify env var loading to follow some common patterns without using complex helpers.
No behaviors were intentionally changed, although a TODO note was added to an odd decision to convert
""to a default in one case.