fix(debug): handle unaligned bus reset captures#8
Draft
gly11 wants to merge 1 commit into
Draft
Conversation
gly11
force-pushed
the
pr/swift-sbp2-connector
branch
from
ab900ba to
62fa6d6
Compare
gly11
force-pushed
the
pr/bus-reset-capture-alignment
branch
from
9ee943e to
85bba25
Compare
gly11
force-pushed
the
pr/swift-sbp2-connector
branch
from
62fa6d6 to
7e2a8e1
Compare
gly11
force-pushed
the
pr/bus-reset-capture-alignment
branch
2 times, most recently
from
c5e3b33 to
b17eeda
Compare
gly11
force-pushed
the
pr/swift-sbp2-connector
branch
from
7e2a8e1 to
b8899e8
Compare
gly11
force-pushed
the
pr/bus-reset-capture-alignment
branch
from
b17eeda to
f7ba5f6
Compare
gly11
force-pushed
the
pr/swift-sbp2-connector
branch
from
b8899e8 to
4c2d153
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is stacked on
pr/swift-sbp2-connectorand fixes bus-reset packet capture handling when the AR buffer data is not naturally aligned.Bus Reset Capture
Why this PR
The capture fix is small and independent. Keeping it separate makes the alignment behavior easy to review without pulling in unrelated driver or app changes.
This PR intentionally does not include debug UI, diagnostic handlers, local scripts, install helpers, or documentation-only planning notes.
Verification
Local verification completed for this slice:
The CMake driver target still needs separate project cleanup because the generated DriverKit header is not available through the current CMake path. Xcode build verification was used as the gate for this slice.