fix broken quartiles method in isoutlier - #482
Conversation
|
You are correct about On another item: your changes purge a Also it helps if you stamp the MATLAB run with version (this is a more general guide rather than specific to this PR). Another thing I noticed in the function (unrelated to your PR, but you are welcome to fix it along) is that all methods that require a second input argument for |
The docstring lost the @EnD itemize closing the output list, so help isoutlier failed with "`@end' expected `itemize', but saw `deftypefn'" and printed the raw texinfo source instead of the formatted text. A trailing space on the ThresholdFactor paragraph goes with it. (PR #482) * inst/Data_Manipulation/isoutlier.m: Close the output list and drop a trailing space.
quartilesmethod inisoutlieralways crashed, because dim was being passed into the wrong argument of quantile. While fixing it, also found the center value formula was wrong - it used the median instead of the average of the 25th and 75th percentiles, which is what MATLAB actually returns.quartiles.BEFORE:
AFTER:
MATLAB: