Skip to content

Fix empty array edge cases in nlinfit #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pr0m1th3as merged 9 commits into from
Sep 16, 2026
+16 −1
Merged

Fix empty array edge cases in nlinfit #485

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
745005d
Fix empty array edge cases in nlinfit
Sonu0305 Sep 14, 2026
162d935
Refactor long error messages to use strcat
Sonu0305 Sep 14, 2026
4646f0d
Fix trailing space issue with strcat in nlinfit
Sonu0305 Sep 14, 2026
9adada0
Refactor tests to use %!error instead of %!fail
Sonu0305 Sep 14, 2026
128fff1
Fix empty array error message formatting in nlinfit
Sonu0305 Sep 15, 2026
75a50f2
fix formatting
Sonu0305 Sep 15, 2026
b1ee124
Remove rows check and update MODELFUN size error in nlinfit
Sonu0305 Sep 16, 2026
cee3298
Fix broadcasting array issue in lm_fit and relax isvector check
Sonu0305 Sep 16, 2026
6fc9d06
Fix errors
Sonu0305 Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion inst/Regression/nlinfit.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,13 @@
if (! (isnumeric (y) && isreal (y)))
error ("nlinfit: Y must be a real numeric vector.");
endif
if (! isvector (y))
error ("nlinfit: Y must be a vector.");
endif

if (! isequal (size (modelfun (beta0(:), X)), size (y)))
error ("nlinfit: MODELFUN must return a vector of the same size as Y.");
endif

beta0 = beta0(:);
y = y(:);
Expand Down Expand Up @@ -242,6 +249,7 @@

beta = beta0;
yhat = modelfun (beta, X);
yhat = yhat(:);
R = y - yhat;
sse = sum (w .* R .^ 2);
lambda = 1e-2; # Marquardt damping
Expand All @@ -260,7 +268,8 @@
A = JtJ + lambda * diagJtJ;
delta = pinv (A) * Jtr;
bnew = beta + delta;
rnew = y - modelfun (bnew, X);
ynew = modelfun (bnew, X);
rnew = y - ynew(:);
ssenew = sum (w .* rnew .^ 2);
if (isfinite (ssenew) && ssenew < sse)
stepok = true;
Expand Down Expand Up @@ -609,5 +618,11 @@
%! assert_equal (bhub, [-0.032803877294096; 2.016488145372473], 1e-7);
%! assert_equal (bboth, bhub, 1e-12);

## Edge cases with empty arrays
%!error <nlinfit: MODELFUN must return a vector of the same size as Y.> ...
%! nlinfit ([], zeros (0, 1), @(b,x) b(1).*x, [1])
%!error <nlinfit: MODELFUN must return a vector of the same size as Y.> ...
%! nlinfit (zeros (0, 3), zeros (0, 1), @(b,x) b(1).*x, [1])

%!error<nlinfit: unknown RobustWgtFun 'bad'.> ...
%! nlinfit ([1;2], [1;2], @(b, x) b(1) * ones (2, 1), 1, "RobustWgtFun", "bad")