Skip to content

Fix empty array edge cases in mnrfit #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pr0m1th3as merged 4 commits into from
Sep 16, 2026
Merged

Fix empty array edge cases in mnrfit #487

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ab1a64
Fix empty array edge cases in mnrfit
Sonu0305 Sep 14, 2026
f733d64
Refactor tests to use %!error instead of %!fail
Sonu0305 Sep 14, 2026
6a96635
Update empty array error message for mnrfit
Sonu0305 Sep 15, 2026
90e40c2
Fix case in mnrfit error and formatting
Sonu0305 Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions inst/Regression/mnrfit.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,10 @@
n = numel (UY); ## number of unique response categories
endif

if (isempty (Y))
error ("mnrfit: X and Y must contain at least one observation.");
endif

if (isnumeric (Y))
if (! (all (Y > 0) && all (fix (Y) == Y)))
error ("mnrfit: Y must contain positive integer category numbers.")
Expand Down Expand Up @@ -661,3 +665,8 @@
%!error<mnrfit: 'estdisp' must be 'on' or 'off'.> ...
%! mnrfit (ones (5, 4), [1; 2; 1; 2; 1], 'estdisp', 'maybe')

## Edge cases with empty arrays
%!error <mnrfit: X and Y must contain at least one observation.> ...
%! mnrfit ([], [])
%!error <mnrfit: X and Y must contain at least one observation.> ...
%! mnrfit (zeros (0, 3), zeros (0, 1))