Skip to content

Fix empty array edge cases in robustfit #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sonu0305 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix empty array edge cases in robustfit #489

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43c214b
Fix empty array edge cases in robustfit
Sonu0305 Sep 14, 2026
0ccc7b7
Refactor tests to use %!error instead of %!fail
Sonu0305 Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions inst/Regression/robustfit.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
if (! (isnumeric (X) && isreal (X) && ismatrix (X)))
error ("robustfit: X must be a real matrix.");
endif
if (! (isnumeric (y) && isreal (y) && isvector (y)))
if (! (isnumeric (y) && isreal (y) && (isvector (y) || isempty (y))))
error ("robustfit: Y must be a real vector.");
endif
y = y(:);
Expand Down Expand Up @@ -114,7 +114,7 @@
endif
[n, p] = size (X);
if (n <= p)
error ("robustfit: not enough observations for the number of parameters.");
error ("robustfit: Not enough points to perform robust estimation.");
endif

## Ordinary least squares start, leverages, and the OLS scale.
Expand Down Expand Up @@ -322,3 +322,10 @@
%! robustfit (X, y, "huber", -1)
%!error <robustfit: CONST must be 'on' or 'off'.> ...
%! robustfit (X, y, "huber", 1.345, "maybe")

%!test
%! ## Edge cases with empty arrays
%!error<robustfit: Not enough points to perform robust estimation.> ...
%! robustfit ([], [])
%!error<robustfit: Not enough points to perform robust estimation.> ...
%! robustfit (zeros(0,3), zeros(0,1))