Fix race in keepalive drain tests - #529
Merged
Merged
Conversation
Co-authored-by: fredbi <14262513+fredbi@users.noreply.github.com>
Co-authored-by: fredbi <14262513+fredbi@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
fredbi
August 30, 2026 15:46
View session
fredbi
marked this pull request as ready for review
August 30, 2026 15:46
fredbi
approved these changes
Aug 30, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
==========================================
- Coverage 87.17% 87.16% -0.02%
==========================================
Files 65 65
Lines 4749 4752 +3
==========================================
+ Hits 4140 4142 +2
- Misses 599 600 +1
Partials 10 10 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI detected a race in
TestDrainingReadCloser: tests reassigned process-globalio.Discardwhilenet/httpbackground drain goroutines could read it.Test isolation
drainingReadCloser.io.Discardas the production default.Race-free assertions