Test/move fixtures to testdata - #235
Merged
Merged
Conversation
The loading, yamlutils and jsonutils benchmarks modules each kept their test material under fixtures/. It now lives in testdata/, joining mangling/testdata which the fuzz corpus already occupied. The Go toolchain gives testdata a defined meaning — package patterns, vet and the build all skip it — whereas fixtures/ was ours alone. Three go:embed directives are retargeted at the renamed directories. The jsonutils/fixtures_test module keeps its name: it is a published module path, and a shared harness rather than a directory of test material. Its package name, its own embedded ordered_fixtures.yaml and the import alias at nine call sites are untouched. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #235 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 57 57
Lines 2704 2704
=======================================
Hits 2494 2494
Misses 166 166
Partials 44 44 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist