fix: normalize tool-call input with schema-aware lossless unwrap#63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LLMs occasionally over-process tool-call arguments — wrapping an object/array in an extra JSON string (whole-argument or single-field stringify). The engine previously coerced any non-object input to an empty object, silently discarding the arguments. This normalizes tool input once, schema-aware and language-agnostic: it losslessly unwraps stringified objects and stringified array/object fields (driven by each tool's declared schema), and preserves non-normalizable input so the tool's own parser returns a clear error the model can correct, instead of running on empty args. The single normalized value is shared by dispatch, history, and display.
Verification
cargo fmt --all— passedcargo clippy --workspace --all-targets -- -D warnings— passedcargo test --workspace— passed (goat-agent 86 tests incl. new normalization cases: whole/field stringify unwrap, string-field protection, multilingual payloads, idempotency, non-object preservation)