Conversation
jmank88
reviewed
Oct 28, 2019
|
|
||
| private _web3Callable$: BehaviorSubject<Web3> = new BehaviorSubject(null); | ||
| private _web3Payable$: BehaviorSubject<Web3> = new BehaviorSubject(null); | ||
| private _web3Metamask$: BehaviorSubject<Web3> = new BehaviorSubject(null); |
Contributor
There was a problem hiding this comment.
Switching back to Metamask specific naming seems backwards. Why don't we keep these general, for example:
walletInstalled$:
walletConfigured$:
_web3Payable$:
Then if/when we switch or add support for others, none of this needs to be updated.
(The user messages can stay metamask specific until we actually add more)
Contributor
Author
There was a problem hiding this comment.
@jmank88 can you check new code, wallet and metamask is different, pk is also wallet
Contributor
|
Configuration cases to test:
|
Contributor
Author
|
@jmank88 if MM available there's no option to enter PK |
# Conflicts: # front/src/app/services/wallet.service.ts
Contributor
|
What are we doing with this? |
Contributor
Author
Contributor
|
No, if they stay on the page, leave the pk in the field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.