policy: the signing-key comments point at #453, not at the retired #35 - #571
Merged
Merged
Conversation
`GitKeyWhitelist`'s comment, GIT-CONFIG.md and GENERATED-CONFIG.md all say the whitelist grows when signing has a design, and all three cite issue #35. #35 is CLOSED — it was a tracker, retired and split — so a reader following the pointer lands somewhere dead. The live ticket is #453. The code comment also gains the two measured facts #453 has to answer and this comment could not, because both are invisible from the whitelist: - a repo-local .git/config with `commit.gpgsign = true` arrives inside regardless of this list. The target is bound and GIT_CONFIG_GLOBAL displaces only the GLOBAL file, so a signed commit from inside fails with the agent proxy's non-pinned-key refusal, `agent refused operation` — which reads as a host keyring fault and is not one. - the agent protocol carries no purpose, so pinning a second key for signing means either key can be used for either purpose by anything inside the sandbox. Comment and prose only. make gate green. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitKeyWhitelist's comment,GIT-CONFIG.mdandGENERATED-CONFIG.mdall say the whitelist grows when signing has a design, and all three cite issue #35.#35 is CLOSED — a tracker, retired and split. Following the pointer lands nowhere. Live ticket is #453.
Also adds to the code comment the two measured facts #453 has to answer, invisible from the whitelist itself:
.git/configwithcommit.gpgsign = truearrives inside regardless of this list — target is bound, andGIT_CONFIG_GLOBALdisplaces only the GLOBAL file. Signed commit from inside then fails with the agent proxy's non-pinned-key refusal,agent refused operation, which reads as a host keyring fault and is not one.Left alone deliberately: five other
#35mentions (envtypes.go,envtypes_test.go,ENVIRONMENT-VARIABLES.mdx2,VERIFY.md). Those read "#35 and #45 asked for this and are answered by the annotation" — provenance for a question that was answered, with the answer named in the same sentence, not a pointer at pending work.Comment and prose only.
make gategreen.🤖 Generated with Claude Code