verify: the signing step asserted a fingerprint %GK cannot print inside - #577
Merged
Merged
Conversation
VERIFY.md's by-hand signing check ran `git log -1 --format=%GK` inside the sandbox and said to expect the signing key's fingerprint. Every `%G` placeholder asks git to VERIFY, and verification needs `gpg.ssh.allowedSignersFile`, which snug does not author (#576). Measured on git 2.55.0: `%GK` prints the allowedSignersFile error on stderr, an empty line on stdout, exit 0; `%G?` prints `N`. The commit object carries `gpgsig -----BEGIN SSH SIGNATURE-----` throughout. So the step has been passing on a line that proves nothing, for the same missing grant it goes on to describe. In-sandbox step now reads the commit object. `git log --show-signature` moved to the HOST, where allowed_signers exists and the check names which key signed — which is what "the signature names the signing key rather than the authentication one" claimed and never tested. Both shapes of the in-sandbox failure are stated: `--show-signature` prints `No signature` and exits 0, `verify-commit` exits 1. Refs #576 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VERIFY.md's by-hand signing step ran
git log -1 --format=%GKINSIDE the sandbox and said to expect the signing key's fingerprint. Every%Gplaceholder asks git to VERIFY, and verification needsgpg.ssh.allowedSignersFile, which snug does not author (#576).Measured, git 2.55.0:
Commit object carries
gpgsig -----BEGIN SSH SIGNATURE-----throughout. So the step passed on a line proving nothing, for the same missing grant it goes on to describe.Change:
git cat-file commit HEAD) — proves signing, asks no verificationgit log --show-signaturemoved to the HOST, whereallowed_signersexists and the check names WHICH key signed. That is what "the signature names the signing key rather than the authentication one" claimed and never tested.--show-signatureprintsNo signatureexit 0;verify-commitexits 1.VERIFY.md only, no compiled change.
make gateexit 0.Refs #576 — the grant itself stays unbuilt.
🤖 Generated with Claude Code