Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions FileOrganizer.Tests/MetadataEngineTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
using System;
using System.Reflection;
using FileOrganizer.Engines;
using Xunit;

namespace FileOrganizer.Tests
{
public class MetadataEngineTests
{
private readonly MetadataEngine _engine = new MetadataEngine();

private string CallSanitizeForPath(string input)
{
var method = typeof(MetadataEngine).GetMethod("SanitizeForPath", BindingFlags.NonPublic | BindingFlags.Instance);
return (string)method.Invoke(_engine, new object[] { input });
}

[Theory]
[InlineData("ValidName", "ValidName")]
[InlineData(" TrimmedName ", "TrimmedName")]
[InlineData("Name/With/Slash", "NameWithSlash")]
[InlineData("Name\\With\\Backslash", "NameWithBackslash")]
[InlineData("..", "Unknown")]
[InlineData("../etc/passwd", "etcpasswd")]
[InlineData(".", "Unknown")]
[InlineData("valid.name", "validname")]
public void SanitizeForPath_RemovesInvalidAndPathTraversalChars(string input, string expected)
{
string actual = CallSanitizeForPath(input);
Assert.Equal(expected, actual);
}
}
}
4 changes: 4 additions & 0 deletions FileOrganizer/Engines/MetadataEngine.cs
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,14 @@ private string GetImageSubFolder(string filePath)
private string SanitizeForPath(string folderName)
{
folderName = folderName.Trim();
// Remove invalid characters for a file name
foreach (char c in Path.GetInvalidFileNameChars())
{
folderName = folderName.Replace(c.ToString(), "");
}
// Remove dots to prevent path traversal (e.g., ".." or ".")
folderName = folderName.Replace(".", "");

return folderName.Length > 0 ? folderName : "Unknown";
}
}
Expand Down