feat(gooddata-sdk): [AUTO] Add CustomUserApplicationSetting CRUD endpoints for per-user app settings#1602
Open
yenkins-admin wants to merge 2 commits into
Open
feat(gooddata-sdk): [AUTO] Add CustomUserApplicationSetting CRUD endpoints for per-user app settings#1602yenkins-admin wants to merge 2 commits into
yenkins-admin wants to merge 2 commits into
Conversation
…oints for per-user app settings
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1602 +/- ##
==========================================
+ Coverage 78.96% 79.02% +0.06%
==========================================
Files 231 232 +1
Lines 15578 15642 +64
==========================================
+ Hits 12301 12361 +60
- Misses 3277 3281 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added full SDK support for the new
CustomUserApplicationSettingCRUD endpoints. Created the entity model classCatalogCustomUserApplicationSettingwith helper methods for serializing to the two distinct API document types (POST vs PATCH). Added five service methods toCatalogUserService(list, get, create, update, delete). Exported the new classes from the public__init__.py. Added an integration test covering the full CRUD lifecycle.Impact: new_feature | Services:
gooddata-metadata-clientFiles changed
packages/gooddata-sdk/src/gooddata_sdk/catalog/user/entity_model/custom_user_application_setting.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/user/service.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/catalog/test_catalog_user_service.pyAgent decisions
Decisions (3)
document serialization helpers vs document wrapper classes — Added as_post_document() and as_patch_document() directly on the entity class rather than separate CatalogXxxDocument / CatalogXxxPatchDocument wrapper classes
camelCase attribute access in from_api — Use ea['applicationName'] / ea.get('workspaceId') (camelCase) when accessing raw API dict in from_api()
workspace_id as optional kwarg — workspace_id defaults to None in CatalogCustomUserApplicationSettingAttributes and passed to API only when non-None
Assumptions to verify (4)
Risks (2)
Layers touched (3)
packages/gooddata-sdk/src/gooddata_sdk/catalog/user/entity_model/custom_user_application_setting.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/user/service.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/catalog/test_catalog_user_service.pySource commits (gdc-nas)
827a35dfeat(metadata-api): add CustomUserApplicationSetting endpoint (#22399)OpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow