feat(gooddata-sdk): [AUTO] Add ErrorInfo schema and error field to SearchResult#1604
Open
yenkins-admin wants to merge 3 commits into
Open
feat(gooddata-sdk): [AUTO] Add ErrorInfo schema and error field to SearchResult#1604yenkins-admin wants to merge 3 commits into
yenkins-admin wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1604 +/- ##
=======================================
Coverage 78.96% 78.96%
=======================================
Files 231 231
Lines 15578 15578
=======================================
Hits 12301 12301
Misses 3277 3277 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added integration test
test_search_ai_error_fieldtotest_compute_service.pyto exercise the newErrorInfoerror field onSearchResult. No SDK wrapper code changes were required becausecompute/service.pyalready returns the rawSearchResultAPI model, and the auto-generated client (updated by the diff) already includes the optionalerror: ErrorInfofield. The test verifies both the success path (error absent, results present) and the failure path (error.reason is str, error.status_code is int).Impact: new_feature | Services:
gooddata-afm-clientTickets: GDAI-1672
Files changed
packages/gooddata-sdk/tests/compute/test_compute_service.pyAgent decisions
Decisions (2)
No SDK wrapper class for ErrorInfo — Return raw SearchResult from API client unchanged; access result.error.reason and result.error.status_code directly
Where to place the new test — Add test_search_ai_error_field to existing test_compute_service.py (module-level skipped)
Assumptions to verify (3)
Risks (1)
Layers touched (1)
packages/gooddata-sdk/tests/compute/test_compute_service.pySource commits (gdc-nas)
259fb34Merge pull request #22412 from gooddata/malmiron/GDAI-1672-error-messageOpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow