feat(gooddata-sdk): [AUTO] Migrate uploadNotification from entities to actions endpoint path#1605
Open
yenkins-admin wants to merge 2 commits into
Open
feat(gooddata-sdk): [AUTO] Migrate uploadNotification from entities to actions endpoint path#1605yenkins-admin wants to merge 2 commits into
yenkins-admin wants to merge 2 commits into
Conversation
…o actions endpoint path
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1605 +/- ##
=======================================
Coverage 78.96% 78.96%
=======================================
Files 231 231
Lines 15578 15580 +2
=======================================
+ Hits 12301 12303 +2
Misses 3277 3277 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
register_workspace_upload_notification(workspace_id)method toCatalogWorkspaceServicethat wraps the new/api/v1/actions/workspaces/{workspaceId}/uploadNotificationendpoint. The generated API client (ActionsApi) already contains theregister_workspace_upload_notificationmethod; only the SDK wrapper layer and integration test were missing. Added an integration test intest_catalog_workspace.pywith a VCR cassette reference.Impact: modification | Services:
gooddata-metadata-clientFiles changed
packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/service.pypackages/gooddata-sdk/tests/catalog/test_catalog_workspace.pyAgent decisions
Decisions (3)
placement of new method — Added to CatalogWorkspaceService in service.py, not to a separate module
no new public init.py export — Did not add export to gooddata_sdk/init.py
test strategy for 204 No Content endpoint — Integration test that calls the method and asserts no exception is raised
Assumptions to verify (3)
Risks (1)
Layers touched (2)
packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/service.pypackages/gooddata-sdk/tests/catalog/test_catalog_workspace.pySource commits (gdc-nas)
90b39ccMerge pull request #22334 from Tjev/cq-2080-endpoint4ef0a1eMerge pull request #22379 from Tjev/cq-2244-ws-ds-removalOpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow