feat(gooddata-sdk): [AUTO] Add dateTimeSemantics (LOCAL/UTC) field to DataSource schemas#1606
Open
yenkins-admin wants to merge 2 commits into
Open
feat(gooddata-sdk): [AUTO] Add dateTimeSemantics (LOCAL/UTC) field to DataSource schemas#1606yenkins-admin wants to merge 2 commits into
yenkins-admin wants to merge 2 commits into
Conversation
… DataSource schemas
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1606 +/- ##
=======================================
Coverage 78.96% 78.96%
=======================================
Files 231 231
Lines 15578 15580 +2
=======================================
+ Hits 12301 12303 +2
Misses 3277 3277 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added dateTimeSemantics (LOCAL/UTC) nullable field to DeclarativeDataSource and JsonApiDataSource* SDK wrapper classes. The generated API client already contained the field; only the hand-written SDK wrappers needed updating. Changes: (1) added date_time_semantics: str | None = None to CatalogDeclarativeDataSource in declarative_model/data_source.py so it round-trips through _get_snake_dict()/from_dict(); (2) added date_time_semantics to _ATTRIBUTES list and as an instance field on CatalogDataSourceBase in entity_model/data_source.py so it is serialized in to_api() and deserialized in from_api(); (3) added test_date_time_semantics integration test that patches a data source with LOCAL and asserts the read-back value.
Impact: modification | Services:
gooddata-metadata-clientFiles changed
packages/gooddata-sdk/src/gooddata_sdk/catalog/data_source/declarative_model/data_source.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/data_source/entity_model/data_source.pypackages/gooddata-sdk/tests/catalog/test_catalog_data_source.pyAgent decisions
Decisions (3)
Field placement in entity model — Added date_time_semantics after alternative_data_source_id in both _ATTRIBUTES list and field definitions
Field type for dateTimeSemantics — str | None = None (nullable optional string)
No public init.py export change needed — Did not modify gooddata_sdk/init.py
Assumptions to verify (3)
Risks (2)
Layers touched (3)
packages/gooddata-sdk/src/gooddata_sdk/catalog/data_source/declarative_model/data_source.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/data_source/entity_model/data_source.pypackages/gooddata-sdk/tests/catalog/test_catalog_data_source.pySource commits (gdc-nas)
56e527cMerge pull request #22246 from gooddata/dho/cq-2235-tz-settingOpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow