🐛 fix: 生成 CSS のアイコンクラスに font-weight: 500 を反映（CLI 2.2.2）#283
Merged
Conversation
- sparkle-design-cli 2.2.2 で sparkle-design.css を再生成 （.icon-*-fill-* 全 24 クラスに font-weight: var(--font-weight-icon) 追加） - Vercel ビルドの CLI ピンを 1.3.11 → 2.2.2 に更新 （ビルド時の再生成にも新テンプレートを反映させるため） - goodpatch/sparkle-design-internal#198 の根本対応（テンプレート側） Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Walkthroughこのプルリクエストは、Sparkle Design のアイコンスタイル定義をアップグレードします。CSS 変数 Changesアイコンスタイリングと CLI アップグレード
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
sparkle-design-cli@2.2.2 のテンプレート更新を取り込み、生成される sparkle-design.css のアイコン用クラスに font-weight: 500 が確実に反映されるようにするPRです。あわせて、Vercel 上の registry build でも同じ CLI バージョンで CSS 再生成が行われるようピンを更新しています。
Changes:
src/app/sparkle-design.cssに--font-weight-icon: 500トークンを追加.icon-*-fill-*（計 24 クラス）にfont-weight: var(--font-weight-icon);を追加scripts/build-registry-vercel.shの CLI ピンをsparkle-design-cli@2.2.2に更新
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/app/sparkle-design.css | アイコンクラスへ font-weight を付与し、トークンで一元管理できるように更新 |
| scripts/build-registry-vercel.sh | Vercel build 時の CSS 再生成が CLI 2.2.2 を使うように更新 |
Comment on lines
10
to
+12
| # Step 1: cssを生成 | ||
| echo "🎨 Generate sparkle-design.css..." | ||
| npx --yes sparkle-design-cli@1.3.11 generate | ||
| npx --yes sparkle-design-cli@2.2.2 generate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
sparkle-variables#1 / sparkle-design-cli v2.2.2 のテンプレート更新を取り込みます（goodpatch/sparkle-design-internal#198 の根本対応）。
変更内容
sparkle-design-cli@2.2.2でsrc/app/sparkle-design.cssを再生成--font-weight-icon: 500トークン追加 +.icon-*-fill-*全 24 クラスにfont-weight: var(--font-weight-icon);追加（差分は +25 行のみ）scripts/build-registry-vercel.shの CLI ピンを1.3.11→2.2.2に更新備考
Iconコンポーネント側font-medium対応と二重の防御になります（重複しても挙動は同じ weight 500）generateが entry CSS（globals.css）に@importを重複挿入する既存バグ（2.2.1 でも再現）を確認したため、globals.css は変更に含めていません。別 issue として報告します🤖 Generated with Claude Code