Preserve single-pass iterables in stack and concat - #105
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
sylvesterkaczmarek
marked this pull request as ready for review
September 23, 2026 08:05
sylvesterkaczmarek
force-pushed
the
fix/single-pass-stack-concat
branch
from
September 30, 2026 14:15
79a0f04 to
dea42f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Materialize the input iterable in
stackandconcatbefore creating their field-processing callbacks. Currently_ops_basematerializes a generator locally, but the callbacks retain the original, exhausted iterator. Both operations then fail while stacking or concatenating the first array field.The two-line fix shares one materialized list across all array and nested-dataclass fields. List-input behavior, static metadata, axis handling, and backend selection are unchanged.
Validation
macOS arm64 CPU, Python 3.12.11; NumPy 2.5.3, JAX 0.11.2, TensorFlow 2.21.0, PyTorch 2.14.0:
python -m pytest -q dataclass_array --tb=short).git diff --checkpass. Ruff E9/F passes with F722 excluded for the project's shape-annotation syntax.Accelerators and documentation builds were not run. This does not change negative-axis handling and is independent of #104.