fix(apps): explicitly preserve language and tools during event compac…#6273#6329
Open
eajajhossain wants to merge 1 commit into
Open
fix(apps): explicitly preserve language and tools during event compac…#6273#6329eajajhossain wants to merge 1 commit into
eajajhossain wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
N/A
Problem:
During long-lived sessions with multiple compaction cycles, massive tool payloads (200K+ chars) cause "Attention Dilution." The model loses its language anchor (e.g., switching to Russian) and hallucinates tools (e.g., calling
run_commandwhich isn't registered) because the defaultLlmEventSummarizerstrips the exact language and tool context during compaction.Solution:
Updated the
_DEFAULT_PROMPT_TEMPLATEinLlmEventSummarizerto include explicitCRITICAL INSTRUCTIONS. The summarizer is now forced to explicitly identify and state the primary conversation language and accurately list the exact tool names used. This ensures these structural anchors survive inside theEventCompactionobject, preserving grounding when the main agent resumes.Testing Plan
Unit Tests:
Passed
pytestresults:Manual End-to-End (E2E) Tests:
Setup:
DatabaseSessionServiceandEventsCompactionConfig(compaction_interval=10).Logs/Evidence:
When running the agent and inspecting the generated
EventCompactionevent in the session storage (or verbose terminal logs), the summary now clearly injects the explicit anchors requested:{ "role": "model", "parts": [ { "text": "Conversation Language: English\nTools Used: fetch_documents, retrieve_by_bank\n..." } ] }This proves the language and tool grounding is successfully retained and passed back to the main agent.
Checklist
Additional context
None