Skip to content

fix(ci): keep sample load smoke tests offline-safe #6344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sehlani042 wants to merge 2 commits into
base: main
Choose a base branch
from
+28 −14
Open

fix(ci): keep sample load smoke tests offline-safe #6344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6d1120
fix(ci): keep ADK sample smoke tests offline-safe
Sehlani042 Jul 8, 2026
9b58bb9
Merge branch 'main' into codex/fix-adk-ci-sample-smoke
rohityan Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions src/google/adk/models/lite_llm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2769,12 +2769,13 @@ def _finalize_tool_call_response(
thought_parts=list(reasoning_parts) if reasoning_parts else None,
)
mapped_finish_reason = _map_finish_reason(finish_reason)
llm_response.finish_reason = mapped_finish_reason
if mapped_finish_reason != types.FinishReason.STOP:
llm_response.error_code = mapped_finish_reason
llm_response.error_message = _finish_reason_to_error_message(
mapped_finish_reason
)
if mapped_finish_reason is not None:
llm_response.finish_reason = mapped_finish_reason
if mapped_finish_reason != types.FinishReason.STOP:
llm_response.error_code = mapped_finish_reason
llm_response.error_message = _finish_reason_to_error_message(
mapped_finish_reason
)
return llm_response

def _finalize_text_response(
Expand All @@ -2790,12 +2791,13 @@ def _finalize_text_response(
thought_parts=list(reasoning_parts) if reasoning_parts else None,
)
mapped_finish_reason = _map_finish_reason(finish_reason)
llm_response.finish_reason = mapped_finish_reason
if mapped_finish_reason != types.FinishReason.STOP:
llm_response.error_code = mapped_finish_reason
llm_response.error_message = _finish_reason_to_error_message(
mapped_finish_reason
)
if mapped_finish_reason is not None:
llm_response.finish_reason = mapped_finish_reason
if mapped_finish_reason != types.FinishReason.STOP:
llm_response.error_code = mapped_finish_reason
llm_response.error_message = _finish_reason_to_error_message(
mapped_finish_reason
)
return llm_response

def _reset_stream_buffers() -> None:
Expand Down
16 changes: 14 additions & 2 deletions tests/unittests/test_samples.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

from __future__ import annotations

import json
import os
from pathlib import Path
import sys
Expand All @@ -23,7 +22,6 @@
from google.adk.apps.app import App
from google.adk.cli.agent_test_runner import test_agent_replay as _test_agent_replay
from google.adk.cli.utils.agent_loader import AgentLoader
from google.genai import types
import pytest

CONTRIBUTING_DIR = Path(__file__).parent.parent.parent / "contributing"
Expand Down Expand Up @@ -126,6 +124,20 @@ def test_sample(sample_dir: Path, test_file: Path, monkeypatch):
"adk_team/adk_answering_agent/gemini_assistant": (
"sub-agent of adk_answering_agent, not independently loadable"
),
"a2a/a2a_auth/remote_a2a/bigquery_agent": (
"requires Google Cloud ADC at import"
),
"integrations/bigquery": "requires Google Cloud ADC at import",
"integrations/bigquery_mcp": "requires Google Cloud ADC at import",
"integrations/bigtable": "requires Google Cloud ADC at import",
"integrations/data_agent": "requires Google Cloud ADC at import",
"integrations/gcs": "requires Google Cloud ADC at import",
"integrations/gcs_admin": "requires Google Cloud ADC at import",
"integrations/google_api": "requires Google Cloud ADC at import",
"integrations/pubsub": "requires Google Cloud ADC at import",
"integrations/spanner": "requires Google Cloud ADC at import",
"integrations/spanner_admin": "requires Google Cloud ADC at import",
"integrations/spanner_rag_agent": "requires Google Cloud ADC at import",
"integrations/oauth_calendar_agent": (
"fetches the Calendar API (calendar v3) discovery doc at import"
),
Expand Down