fix(litellm): validate tool-call JSON on aborted streams too - #6937
Open
lllakshit wants to merge 1 commit into
Open
fix(litellm): validate tool-call JSON on aborted streams too#6937lllakshit wants to merge 1 commit into
lllakshit wants to merge 1 commit into
Conversation
_finalize_tool_call_response only checked malformed tool-call arguments when finish_reason was length. Streams that abort mid-tool-call end with no finish_reason, so partial arguments reached json.loads and raised an uncaught JSONDecodeError that killed the invocation. Validate assembled arguments unconditionally and return the existing MAX_TOKENS error response when parsing fails. Fixes google#6716
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When a LiteLLM stream aborts mid-tool-call, the stream often ends with no finish_reason. The truncation guard only ran for finish_reason == length, so partial arguments were finalized and json.loads raised an uncaught JSONDecodeError.
This matches the fix shape discussed on #6716 after #6720 was closed.
Test plan
Fixes #6716
Made with Cursor