Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
Closes #7650. Following the maintainer invitation.
After tool confirmation resumes a workflow, a single-turn LlmAgent loses its transient node input and its model request starts with the workflow message. Restore that input before the node run's earlier events, keeping the confirmation FunctionResponse at the tail. The existing cleanup removes the synthetic event; it is not persisted. Task mode and resumes without matching node history retain their existing behavior.
Testing Plan
Complete unit-suite results:
Each failure is
tests/unittests/integrations/vmaas/test_agent_engine_environment.py::test_reading_directory_raises(expected OSError was not raised). I also reproduced that individual failure on unmodified main in each matching environment; I have not attributed its root cause. Commands:tox -p 2; the completed Python 3.12 rerun usedtox -e py312 -o -x 'testenv.commands=pytest tests/unittests -n 2', with no exclusions.Full pre-commit checks pass. Focused mypy passes; full mypy comparisons in test-extra environments add no errors to main's existing errors, and are not a claim that global typing or remote CI is green.
Manual E2E: An offline public Runner with scripted BaseLlm, FunctionTool requiring confirmation and InMemorySessionService reproduces the issue with socket connections disabled. Run once, return the requested confirmation FunctionResponse, then inspect the resumed model request: the node input leads and the tool response remains last. The same reproduction passes from a built wheel in a fresh environment. No real model/provider validation was performed.
Checklist
Additional context
This addresses confirmation resume only. Ordinary cancellation and multiple confirmations answered in one message are outside this fix.