Skip to content

docs(telemetry): disable all content paths in the admin lock recipe - #7739

Closed
BlueRaddish wants to merge 1 commit into
google:mainfrom
BlueRaddish:fix/oct26a-telemetry-admin-lock
Closed

BlueRaddish wants to merge 1 commit into
google:mainfrom
BlueRaddish:fix/oct26a-telemetry-admin-lock

Conversation

@BlueRaddish

Copy link
Copy Markdown
Contributor

Link to Issue or Description of Change

The administrative lock recipe disables legacy span capture and ignores request overrides, but an inherited OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT setting can still enable message content in spans or logs. Export NO_CONTENT explicitly so the documented opt-out covers those paths too.

This is a small documentation correction, covered by the small-documentation linked-issue exception in CONTRIBUTING.md.

Testing Plan

Ran the unchanged repository checks on Linux with Python 3.11–3.14. Each lane also ran the real in-memory Runner with a deterministic local BaseLlm and SDK in-memory span/log exporters: both telemetry schemas, all four inherited capture modes, and a request that attempts to enable capture. The original recipe produces six actual content-policy failures and two passing disabled controls per lane; the corrected recipe passes the same eight cases. A socket guard confirms no network attempt in these consumers.

The two owning telemetry suites pass with zero failures/errors/skips (py311: 218, py312: 218, py313: 218, py314: 218). Full tox results:

Lane Passed Skipped Xfailed Xpassed
py311 21341 96 18 2
py312 21332 97 18 2
py313 21332 97 18 2
py314 21334 95 18 2

Ran uv sync --all-extras, then all four tox -e <lane> environments sequentially. The full command remains pytest tests/unittests; only --junitxml=... was added for reporting, with its effective command and unchanged tox configuration checked. Ordinary scoped pre-commit checks and the installed native commit hook pass (10 hooks were nonapplicable to this documentation file).

No live provider/model, browser, built-wheel quickstart or upstream CI success is claimed. Runtime source and test files are unchanged.

Checklist

  • I have read CONTRIBUTING.md and reviewed the change.
  • The documented recipe was exercised through the real Runner and exporters.
  • All four required full tox environments completed successfully, with the skips and expected-failure results above.
  • Ordinary scoped and native commit hooks passed.

Additional context

AI-assisted with OpenAI Codex.

Set the OpenTelemetry capture policy alongside the legacy ADK knob,
so an inherited capture setting cannot defeat the documented opt-out.

AI-assisted with OpenAI Codex.
copybara-service Bot pushed a commit that referenced this pull request Oct 28, 2026
@adk-bot

adk-bot commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Thank you @BlueRaddish for your contribution! 🎉

Your changes have been successfully imported and merged via Copybara in commit 34750dc.

Closing this PR as the changes are now in the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged [Status] This PR is merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants