Repository navigation
docs(telemetry): disable all content paths in the admin lock recipe - #7739
Closed
BlueRaddish wants to merge 1 commit into
Closed
BlueRaddish wants to merge 1 commit into
BlueRaddish wants to merge 1 commit into
Conversation
Set the OpenTelemetry capture policy alongside the legacy ADK knob, so an inherited capture setting cannot defeat the documented opt-out. AI-assisted with OpenAI Codex.
copybara-service Bot
pushed a commit
that referenced
this pull request
Oct 28, 2026
Merge #7739 PiperOrigin-RevId: 1008846074
Collaborator
|
Thank you @BlueRaddish for your contribution! 🎉 Your changes have been successfully imported and merged via Copybara in commit 34750dc. Closing this PR as the changes are now in the main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
The administrative lock recipe disables legacy span capture and ignores request overrides, but an inherited
OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENTsetting can still enable message content in spans or logs. ExportNO_CONTENTexplicitly so the documented opt-out covers those paths too.This is a small documentation correction, covered by the small-documentation linked-issue exception in CONTRIBUTING.md.
Testing Plan
Ran the unchanged repository checks on Linux with Python 3.11–3.14. Each lane also ran the real in-memory Runner with a deterministic local
BaseLlmand SDK in-memory span/log exporters: both telemetry schemas, all four inherited capture modes, and a request that attempts to enable capture. The original recipe produces six actual content-policy failures and two passing disabled controls per lane; the corrected recipe passes the same eight cases. A socket guard confirms no network attempt in these consumers.The two owning telemetry suites pass with zero failures/errors/skips (py311: 218, py312: 218, py313: 218, py314: 218). Full tox results:
Ran
uv sync --all-extras, then all fourtox -e <lane>environments sequentially. The full command remainspytest tests/unittests; only--junitxml=...was added for reporting, with its effective command and unchanged tox configuration checked. Ordinary scoped pre-commit checks and the installed native commit hook pass (10 hooks were nonapplicable to this documentation file).No live provider/model, browser, built-wheel quickstart or upstream CI success is claimed. Runtime source and test files are unchanged.
Checklist
Additional context
AI-assisted with OpenAI Codex.