Repository navigation
fix(cli): default deploy images to Python 3.12 - #7795
Open
ninglinLiu wants to merge 14 commits into
Open
ninglinLiu wants to merge 14 commits into
ninglinLiu wants to merge 14 commits into
Conversation
Agent Engine / Cloud Run / GKE / Docker deploys defaulted to python:3.11-slim. google-cloud-modelarmor (and the Model Armor plugin) warn that Python 3.11 support ends in 2027-10 and ask for at least 3.12. Bump _DEFAULT_PYTHON_VERSION and the matching CLI defaults to 3.12. --python_version and .agent_engine_config.json still accept 3.11+. Fixes google#7775 AI assistance: Cursor was used to draft this change; I reviewed and tested it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agent Engine / Cloud Run / GKE / Docker deploys defaulted to
python:3.11-slim.google-cloud-modelarmor(and the Model Armor plugin) warn that Python 3.11 support ends in 2027-10 and ask for at least 3.12.Bump
_DEFAULT_PYTHON_VERSIONand the matching CLI defaults to 3.12.--python_versionand.agent_engine_config.jsonstill accept 3.11+.Fixes #7775
Test plan
uv run pytest tests/unittests/cli/utils/test_cli_deploy.py -k python_versionuv run pytest tests/unittests/cli/utils/test_cli_deploy_to_cloud_run.py -k 'dockerfile or python'AI assistance: Cursor was used to draft this change; I reviewed and tested it.