Repository navigation
fix(firestore): only reject ids that fully match __.*__ - #7856
Open
ninglinLiu wants to merge 14 commits into
Open
ninglinLiu wants to merge 14 commits into
ninglinLiu wants to merge 14 commits into
Conversation
startswith/endswith("__") also matched "__" and "___" because the
prefix and suffix overlap, but Firestore's reserved pattern needs at
least four characters. Use re.fullmatch so those valid document ids
are accepted again.
Fixes google#7855
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FirestoreSessionService._validate_identity_componentrejected ids matchingstartswith("__") and endswith("__"). That is broader than Firestore's reserved__.*__pattern:"__"and"___"are valid document ids (the prefix and suffix overlap), but they were rejected after #7801.This switches the check to
re.fullmatch(r"__.*__", value)so only true reserved ids are rejected.Test plan
"__"/"___"/"user__"/"__user"/"_x_"are accepted and"____"/"__x__"/"__reserved__"are rejectedFixes #7855